Added special handling to booleanPointOnLine for zero length lines #2751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urning false positives for points on the same longitude as zero length lines.
|
Merging this will clear the way to getting a couple of cleanCoords bugs fixed as well. |
|
@JamesLMilner or @mfedderly could I please request someone cast an eye over this? There are a couple of other issues - cleanCoords and simplify - that can proceed once this is merged. |
mfedderly
reviewed
Dec 9, 2024
|
|
||
| // Special cases for zero length lines | ||
| // https://github.com/Turfjs/turf/issues/2750 | ||
| if (Math.abs(dxl) === Math.abs(dyl) && Math.abs(dxl) === 0) { |
There was a problem hiding this comment.
Does this math need to be done with some small epsilon for the float comparison instead of ===?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where the point was on the same longitude as a zero length line, even if the point was far away, booleanPointOnLine would return true.
Resolves #2750