You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Should the Point be ignored if the other geometries are homogeneous? E.g. would a LineString be ignored if a FeatureCollection also had two MultiPolygons?
The text was updated successfully, but these errors were encountered:
@langsmith It appears from the code the that intent is to allow heterogeneous collections. In fact, the code explicitly creates a group for each basic type (multipoint, multiline, and multipolygon) and includes output data for each type for which there was data of that type in the input collection.
As for why the coordinates of the point were not included in the test, my guess is that it was just an oversight by whomever wrote the test. But the test does explicitly check the multipoint type is included in the output, so it should be there.
Got it. Ok so, the final FeatureCollection in that test should theoretically have a MultiPoint (containing that single Point) and a MultiPolygon (containing the Polygon and MultiPolygon).
I'm wondering what to make of the
heterogenous
test at https://github.com/Turfjs/turf/blob/master/packages/turf-combine/test.js#L154-L203.I'm finishing up a Java port of the method and unsure how to interpret what this test means. Based on the docs at http://turfjs.org/docs/#combine and the other tests in https://github.com/Turfjs/turf/blob/master/packages/turf-combine/test.js, it appears as if a
Point
mixed with aPolygon
andMultiPolygon
, would not be allowed by this method.The
Point
is added at https://github.com/Turfjs/turf/blob/master/packages/turf-combine/test.js#L188, but thePoint
's coordinates aren't checked at https://github.com/Turfjs/turf/blob/master/packages/turf-combine/test.js#L195-L200Should the
Point
be ignored if the other geometries are homogeneous? E.g. would aLineString
be ignored if aFeatureCollection
also had twoMultiPolygon
s?The text was updated successfully, but these errors were encountered: