children is rendered 2 times on successful loading of image. Why?

[efleurine]

In the code there are two references to children props where it is rendrerd. The first one here

react-native-image-placeholder/index.js

Line 50 in 64ca8c7

(this.state.isLoaded && !this.state.isError) ? children :

and the second one here

react-native-image-placeholder/index.js

Line 73 in 64ca8c7

this.props.children

If I close my network so the network image is inaccessible then only the second one will be rendered. But with a successful loading both will rendered.

I could not figure out why ?

Do we really need that?

thanks for helping me understand.

[sjonchhe]

You can fix it by removing from line 69 to 76
{
this.props.children &&

{
this.props.children
}

}