Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with link cards for installers #9

Open
Kacper-RF opened this issue Mar 2, 2023 · 11 comments
Open

Issue with link cards for installers #9

Kacper-RF opened this issue Mar 2, 2023 · 11 comments
Assignees
Labels
bug Something isn't working

Comments

@Kacper-RF
Copy link

I found small bug on current website https://tryquiet.org/

Sometimes after opening a website cards with links to installers have different order and wrong links.
This also happens when reloading the page.
I recorded short clip about this, please look in left down corner where link address appears

web-problem.mp4
@holmesworcester
Copy link
Contributor

What a weird issue. I can't reproduce that in FF/Ubuntu or Chrome/ChromeOS. Maybe we could remove any script logic in relation to those buttons?

@holmesworcester
Copy link
Contributor

holmesworcester commented Mar 2, 2023

Here's how I think we should approach this:

  • webflow.js is minified and inscrutable. we should remove it.
  • Removing it will break the screenshot animation and the "hamburger" menu in the top nav on mobile screen sizes. the screenshot animation is nice but we can drop it. the hamburger menu is important.
  • Restore the hamburger menu with a little bit of react or vue.js or something.

@holmesworcester
Copy link
Contributor

@josephlacey these pages are in the gh-pages branch in the quiet project

@josephlacey
Copy link

@holmesworcester I'm seeing an error for the attached mp4, "Video can't be played because the file is corrupt," so I'm not exactly sure what's going on here. The proposed changes seem fine, but I want to make sure I'm fixing the correct problem.

@holmesworcester
Copy link
Contributor

I'm seeing an error for the attached mp4, "Video can't be played because the file is corrupt," so I'm not exactly sure what's going on here.

Weird. I see a problem in the github app on mobile but not on desktop. I can confirm that I can download the following file and play it in VLC on debian:

222465472-11ddb7d7-4681-4098-9d07-4f4a4e7a504e.mp4

@josephlacey
Copy link

I'm seeing an error for the attached mp4, "Video can't be played because the file is corrupt," so I'm not exactly sure what's going on here.

Weird. I see a problem in the github app on mobile but not on desktop. I can confirm that I can download the following file and play it in VLC on debian:

Weird indeed. I can play this in Chrome. I wonder if Firefox is blocking something, or there's some telemetry that one of my extensions is blocking. Regardless I see the problem. I'll try to duplicate it.

@holmesworcester
Copy link
Contributor

holmesworcester commented Apr 19, 2023

If we're not loading webflow.js in that page anymore it may be fixed already. I think your prior should be "this is fixed", if we aren't loading any javascript from webflow and you can't reproduce it.

@josephlacey
Copy link

@holmesworcester webflow.js does still load on the page, and it handles the header image animation, so I'd have to replicate that if we were to remove it.

That said I can't duplicate the behavior in the video. @Kacper-RF Do you recall the browser you used when you saw this behavior?

@holmesworcester
Copy link
Contributor

It's probably best to remove webflow.js and fix the hamburger menu. Animations aren't critical.

@holmesworcester holmesworcester moved this from Next Sprint to Backlog - Joining Community in Quiet Apr 20, 2023
@josephlacey
Copy link

@holmesworcester PR to remove Webflow submitted. Still unsure about the original bug report, but hopefully this fixes the problem.

@holmesworcester holmesworcester moved this from Backlog - Joining Community to Waiting for review in Quiet Apr 25, 2023
@siepra
Copy link

siepra commented Apr 28, 2023

@josephlacey could you link PR to the tickets? It's really helpfull ;)
TryQuiet/quiet#1483

@siepra siepra moved this from Waiting for review to Done in Quiet May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

4 participants