Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect to already running Tor process on mobile #296

Closed
siepra opened this issue Mar 3, 2022 · 6 comments
Closed

Connect to already running Tor process on mobile #296

siepra opened this issue Mar 3, 2022 · 6 comments
Assignees

Comments

@siepra
Copy link
Contributor

siepra commented Mar 3, 2022

I think it's crucial for several reasons:

  1. User may have already been using a Tor service (e.g. Orbot) - atm it'll collide with our application
  2. OS is in charge of killing processes when running out of resources. It means we cannot guarantee our key processes running simultaneously all the time. We should think of them as a separate things that can connect to each other when needed, to preserve flexibility
  3. Spawning new Tor process may collide with the one already running, crashing application at start time (reliability issue)
@siepra siepra self-assigned this Mar 18, 2022
@siepra siepra removed their assignment Mar 18, 2022
@siepra siepra self-assigned this Mar 21, 2022
@siepra siepra removed their assignment Mar 21, 2022
@EmiM
Copy link
Contributor

EmiM commented Aug 17, 2022

I ran into (probably) related error while trying to retry registrating username. It's quite annoying

08-17 14:13:29.959 27190 27389 E NODEJS-MOBILE: Error: TOR: Connection already established
08-17 14:13:29.959 27190 27389 E NODEJS-MOBILE:     at /data/user/0/com.zbaymobile/files/nodejs-project/lib/torManager/TorControl.js:30:28
08-17 14:13:29.959 27190 27389 E NODEJS-MOBILE:     at new Promise (<anonymous>)
08-17 14:13:29.959 27190 27389 E NODEJS-MOBILE:     at TorControl.<anonymous> (/data/user/0/com.zbaymobile/files/nodejs-project/lib/torManager/TorControl.js:28:26)
08-17 14:13:29.959 27190 27389 E NODEJS-MOBILE:     at Generator.next (<anonymous>)
08-17 14:13:29.959 27190 27389 E NODEJS-MOBILE:     at /data/user/0/com.zbaymobile/files/nodejs-project/lib/torManager/TorControl.js:8:71
08-17 14:13:29.959 27190 27389 E NODEJS-MOBILE:     at new Promise (<anonymous>)
08-17 14:13:29.959 27190 27389 E NODEJS-MOBILE:     at __awaiter (/data/user/0/com.zbaymobile/files/nodejs-project/lib/torManager/TorControl.js:4:12)
08-17 14:13:29.959 27190 27389 E NODEJS-MOBILE:     at TorControl.connect (/data/user/0/com.zbaymobile/files/nodejs-project/lib/torManager/TorControl.js:27:16)
08-17 14:13:29.959 27190 27389 E NODEJS-MOBILE:     at TorControl.<anonymous> (/data/user/0/com.zbaymobile/files/nodejs-project/lib/torManager/TorControl.js:62:24)
08-17 14:13:29.959 27190 27389 E NODEJS-MOBILE:     at Generator.next (<anonymous>)
08-17 14:13:29.964 27190 27381 E nodejs  : /data/user/0/com.zbaymobile/files/nodejs-project/lib/libp2p/connectionsManager.js:232
08-17 14:13:29.964 27190 27381 E nodejs  :             throw new Error();

@siepra
Copy link
Contributor Author

siepra commented Aug 26, 2022

We'll bind tor process to main application thread (instead of running it in background task) so I think all related problems should disappear. Although it'd be good to confirm that

@vinkabuki
Copy link
Contributor

Didn't solve my problems so I suppose it didn't help

@siepra
Copy link
Contributor Author

siepra commented Aug 30, 2022

We need to gather more information about tor process

@holmesworcester
Copy link
Contributor

I'm moving this to mobile backlog and we can return to it if we suspect it as a cause

@siepra
Copy link
Contributor Author

siepra commented Oct 25, 2022

I don't think this one is accurate anymore

@siepra siepra closed this as completed Oct 25, 2022
@holmesworcester holmesworcester moved this to Done in Quiet Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

4 participants