Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sigchain-powered invite links #2627

Open
adrastaea opened this issue Oct 8, 2024 · 1 comment
Open

Add Sigchain-powered invite links #2627

adrastaea opened this issue Oct 8, 2024 · 1 comment
Assignees
Labels
3.X v3.X lfa Features related to local-first-web/auth implementation

Comments

@adrastaea
Copy link
Collaborator

adrastaea commented Oct 8, 2024

Description

Before we can sync a sigchain, we need to enable an invite flow which means that we must be able to create invites and share the invite secrets alongside other necessary connection info

Acceptance Criteria

  1. Long lived invite created when the invite link is generated
  2. Invite link includes invite secret
  3. Invite link is displayed in “Add members” UI / QR code
  4. Invite link is short enough to stay linkified / not be truncated in WhatsApp, Signal
  5. Failing to generate LFAInviteLink will generate InviteLinkV1 (e2e test compatibility feature)
  6. Test for generating valid invite link
@adrastaea adrastaea added this to Quiet Oct 8, 2024
@adrastaea adrastaea converted this from a draft issue Oct 8, 2024
@adrastaea adrastaea added the lfa Features related to local-first-web/auth implementation label Oct 8, 2024
@islathehut islathehut self-assigned this Nov 13, 2024
@islathehut
Copy link
Collaborator

Marking for posterity:

  • Maximum link length on Signal: 1600 (unofficial but user reported)
  • Maximum link length on WhatsApp: 4096 (no link-specific link length but that is the message limit)

@islathehut islathehut moved this from Waiting for review to In progress in Quiet Dec 3, 2024
@islathehut islathehut added the 3.X v3.X label Dec 3, 2024
@islathehut islathehut moved this from In progress to Waiting for review in Quiet Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.X v3.X lfa Features related to local-first-web/auth implementation
Projects
Status: Waiting for review
Development

No branches or pull requests

2 participants