Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer address of the peer that is sharing the invitee link is not included in the invite link #2266

Closed
kingalg opened this issue Feb 1, 2024 · 4 comments
Assignees
Labels
bug Something isn't working desktop mobile

Comments

@kingalg
Copy link
Collaborator

kingalg commented Feb 1, 2024

[email protected]
[email protected] | iOS 350
System: all

Issue: It can happen that the peer address of the peer that is sharing the invitee link is not included in the invite link. If this happens and none of the other users included in the invite link are online, new users cannot join the community.

Example:
This is the invite link generated by a peer:
https://tryquiet.org/join#QmZJN1sofDCWkdG53Z8vmh3mzZGTSoSE9ThEszS7TSLpzY=bjjlqjw2yyi4yi3edyuotlbf4fs7h7wiamjtnzvbyass5beitnxhfcid&QmTqNNfZGLdhou9ZhJaEYyAU3brK6gzicXzxVhgQV9FDTm=6fpd6qyg7b2asrmhu5ywkzexypame5sltpiy5zpf7gjuazljsj7z3tad&QmShC1b3ZpNGtJ8JzbwMU9djqtovaMR6fou6AUdc3unh7U=6xerfdhia2noyuf6f6bwbkw4rlrtn4uxykzcpscctcumuijkdto4yxyd&k=0w8bXoV45v6giuCWv%2B2P0z7GNURbWjsdEfXyZ3Myu0U%3D&o=0329a60cf1590c253ffed0898aa8f4584a0c7c42a2f2daeda1608327695d30b644
And this is his peer address:
peer: QmTxxPfefm93WFbBYjPS9NeG3RT9YEr62hf9yJ6XmQJuwj

@kingalg kingalg added the bug Something isn't working label Feb 1, 2024
@kingalg kingalg added this to Quiet Feb 1, 2024
@kingalg kingalg moved this to In progress in Quiet Feb 1, 2024
@kingalg kingalg removed their assignment Feb 1, 2024
@EmiM
Copy link
Contributor

EmiM commented Feb 1, 2024

I managed to replicate that on first try with only 5 peers in community (however I'm sure 4 is enough since we only add 3 peerId:onionAddress pairs to invitation link).
One of the peers doesn't have it's own pair in invitation link.
It's probably because in redux Connection -> peerStats don't include its stats which causes peer address to land at the end of sorted peerList.

@EmiM
Copy link
Contributor

EmiM commented Feb 2, 2024

#2268

@EmiM EmiM moved this from In progress to Waiting for review in Quiet Feb 2, 2024
@EmiM EmiM moved this from Waiting for review to Merged in Quiet Feb 5, 2024
@EmiM
Copy link
Contributor

EmiM commented Feb 5, 2024

Information for @kingalg: now local peer's (the one who invites) address should be first on the list of peers in invitation link.

@kingalg
Copy link
Collaborator Author

kingalg commented Feb 9, 2024

Version: 2.1.1-alpha.1
[email protected] | iOS 351

Fixed.

As @EmiM mentioned, the local peer's address is the first one on the list of peers.
Screenshot 2024-02-08 at 10 39 05

@kingalg kingalg closed this as completed Feb 9, 2024
@kingalg kingalg moved this from Merged to Done in Quiet Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working desktop mobile
Projects
Archived in project
Development

No branches or pull requests

2 participants