Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deep linking issues #2253

Closed
siepra opened this issue Jan 26, 2024 · 3 comments
Closed

Deep linking issues #2253

siepra opened this issue Jan 26, 2024 · 3 comments
Assignees
Labels
bug Something isn't working iOS mobile

Comments

@siepra
Copy link
Contributor

siepra commented Jan 26, 2024

We're experiencing several problems sharing the same origin which is abnormal behaviour triggered by using deep linking.
In order to make debugging easier, I decided to merge independently reported issues into the single task.

Overall reproduction steps presents as follows:

  1. Open the app
  2. Pass the network creation phase (eg. by reaching username registration)
  3. Use deep linking feature (open the app from url)
  4. (optional) Leave a community before executing step no. 3

(Draft) PR
#2154

Originally reported task:
#1970

@siepra siepra added this to Quiet Jan 26, 2024
@siepra siepra converted this from a draft issue Jan 26, 2024
@siepra siepra added bug Something isn't working mobile labels Jan 26, 2024
@siepra siepra self-assigned this Jan 26, 2024
@siepra
Copy link
Contributor Author

siepra commented Jan 29, 2024

Another important observation:
Deep linking issues have nothing to do with leaving community. If one leave community and then rejoin pasting invite link instead of using deep linking feature, it works correctly.
On the other hand, it's enough to just open the app (and wait for state-manager sagas to be forked) and then use deep linking feature to mess up the app.

@kingalg
Copy link
Collaborator

kingalg commented Jan 29, 2024

On fix/1970 branch Android seems to work fine, so the problem is likely iOS specific.

I will check it again (on both Android and iOS) once the mentioned branch is merged into develop and released with the alpha version. I'll also check for any other abnormalities.

We agreed with @siepra that any spotted issues will be reported as new tasks, no sooner than fix/1970 is merged, to avoid chaos and confusion.

@siepra siepra moved this from In progress to Waiting for review in Quiet Jan 30, 2024
@siepra siepra moved this from Waiting for review to Merged in Quiet Jan 31, 2024
@siepra siepra moved this from Merged to (Mobile) Ready for QA in Quiet Jan 31, 2024
@kingalg
Copy link
Collaborator

kingalg commented Feb 1, 2024

[email protected] | iOS 350

Fixed.

@kingalg kingalg closed this as completed Feb 1, 2024
@kingalg kingalg moved this from (Mobile) Ready for QA to Done in Quiet Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working iOS mobile
Projects
Archived in project
Development

No branches or pull requests

2 participants