Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User joining with invalid PSK should see error #2014

Closed
holmesworcester opened this issue Oct 26, 2023 · 1 comment
Closed

User joining with invalid PSK should see error #2014

holmesworcester opened this issue Oct 26, 2023 · 1 comment
Labels
joining testing & reliability

Comments

@holmesworcester
Copy link
Contributor

holmesworcester commented Oct 26, 2023 •
edited
Loading

In #1897 we began using libp2p private networks with a PSK for connection authentication. We get an error when the PSK is invalid but we are not displaying this to the user. We should!

If a user can connect to peers but gets rejected because of a PSK error, we should show that. However, the user should keep trying to connect to other peers, at least until all peers give the same error.

(Maybe the peer giving an error is in some incorrect state or has gone rogue.)

We can show this error in the connection startup sequence. "Invalid pre-shared key. Retrying."
@holmesworcester holmesworcester converted this from a draft issue Oct 26, 2023
@holmesworcester holmesworcester mentioned this issue Oct 26, 2023
Closed
@holmesworcester
Copy link
Contributor Author

Deprecating PSK for auth

@holmesworcester holmesworcester removed this from Quiet Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
joining testing & reliability
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@holmesworcester