-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Username changes should be visible immediately (allUsers should prefer certificates over CSRs) #1895
Comments
This relates to which username will show when a user has a pending request to change their username: their new requested name or their existing name. |
@holmesworcester Do you have an idea for how to move forward with this? Should we show the registered username until a pending username is registered? Or should we show a pending username if there is one? I think currently, we are doing the latter. Also do you think we can address this later? To me, it doesn't seem like it should hold up the release necessarily, but curious to hear your thoughts. |
I think showing the pending username is correct. If that's the current behavior and there aren't other questions let's close this. |
I'm not sure if it is the current behavior. Looking at the code again, it looks like it prefers the cert: quiet/packages/state-manager/src/sagas/users/users.selectors.ts Lines 85 to 96 in f94151b
|
Then let's leave it open but move it out of this sprint. I renamed the issue to make it clear what the product-level impact is. |
Sounds good, thanks! |
displayableCurrentChannelMessages
selector usesallUsers
to select the username for a message. If CSRs have precedence over certs, then it could display an invalid/old username for that user.allUsers
is also used indisplayMessageNotificationSaga
andshowNotificationSaga
to get the username for a notification.The text was updated successfully, but these errors were encountered: