Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There should only be one active CSR per public key #1892

Closed
Tracked by #1902
leblowl opened this issue Oct 3, 2023 · 3 comments
Closed
Tracked by #1902

There should only be one active CSR per public key #1892

leblowl opened this issue Oct 3, 2023 · 3 comments
Labels
joining needs migration Needs data migration code for backward compatibility

Comments

@leblowl
Copy link
Contributor

leblowl commented Oct 3, 2023

This reduces the amount of CSRs loaded into memory. There should only be one active CSR per pubKey.

@holmesworcester
Copy link
Contributor

holmesworcester commented Oct 3, 2023

This seems like part of this existing round of work and something we should do before release.

@leblowl leblowl added the needs migration Needs data migration code for backward compatibility label Oct 3, 2023
@leblowl
Copy link
Contributor Author

leblowl commented Oct 5, 2023

Initially I was thinking we can use a key/value store for CSRs, however I think it's important to maintain some sense of order with the CSRs. The key/value store doesn't maintain insertion order in the version of OrbitDB we are using (the in-memory data structure is just a plain JS object). So I think we should keep this as an event store for now. However, I think this is still true:

There should only be one active CSR per pubKey.

And we don't want old CSRs piling up in memory. So at some point I think we will want to have an approach for deleting CSRs such that there is only one per public key. And for now we can just be careful to only process the most recent CSR for each public key.

@leblowl leblowl changed the title certificatesRequests should be a key/value store pubKey -> CSR There should only be one active CSR per public key Oct 5, 2023
@leblowl leblowl moved this from Sprint to Backlog - Desktop & Backend in Quiet Oct 5, 2023
@holmesworcester
Copy link
Contributor

Deprecating this approach to usernames. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
joining needs migration Needs data migration code for backward compatibility
Projects
None yet
Development

No branches or pull requests

2 participants