Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running Chromatic tests for forked PRs #1775

Closed
leblowl opened this issue Sep 8, 2023 · 8 comments
Closed

Running Chromatic tests for forked PRs #1775

leblowl opened this issue Sep 8, 2023 · 8 comments
Assignees

Comments

@leblowl
Copy link
Collaborator

leblowl commented Sep 8, 2023

I think it would be nice to allow a maintainer to run Chromatic visual regression tests for PRs from forked repos. Currently, it appears that it's necessary to create a branch on the quiet repo.

@holmesworcester holmesworcester moved this to Next Sprint in Quiet Sep 8, 2023
@holmesworcester
Copy link
Contributor

Sounds good to me. Putting this in "Next sprint" but you can do it whenever!

@Kacper-RF
Copy link
Contributor

I think there are two solutions:

  1. External collaborator should add chromatic secret to his settings in forked repository.
  2. Marek suggested that if You(Holmes) give this token to external collaborators when they ask, maybe it should be plain text ? It will probably completely remove the problem of running this workflow by other collaborators, but I know this may not be optimal for security reasons.

@holmesworcester
Copy link
Contributor

I don't understand what you mean by plain text. You mean just put it in the repo?

@Kacper-RF
Copy link
Contributor

Yes

@holmesworcester
Copy link
Contributor

I have to check if chromatic has capped billing, or if there are other potential security issues.

I really don't like it, by default.

Can we run these tests ourselves for outside contributors?

@siepra
Copy link
Contributor

siepra commented Sep 18, 2023

@holmesworcester Chromatic's documentation says for oss forks we should just commit the project token as plaintext
https://www.chromatic.com/docs/github-actions#run-chromatic-on-external-forks-of-open-source-projects

@holmesworcester
Copy link
Contributor

Okay let's do it!

@Kacper-RF Kacper-RF moved this from Next Sprint to In progress in Quiet Sep 26, 2023
@Kacper-RF Kacper-RF moved this from In progress to Waiting for review in Quiet Sep 26, 2023
@Kacper-RF
Copy link
Contributor

Kacper-RF commented Sep 26, 2023

#1862
forked: #1820

@Kacper-RF Kacper-RF moved this from Waiting for review to Merged (develop) in Quiet Sep 26, 2023
@Kacper-RF Kacper-RF moved this from Merged (develop) to Done in Quiet Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

4 participants