Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User should be able to tap/click on "unregistered" label to learn what it means #1649

Closed
vinkabuki opened this issue Jul 19, 2023 · 13 comments
Closed
Assignees
Labels

Comments

@vinkabuki
Copy link
Contributor

vinkabuki commented Jul 19, 2023

When we let users join without the community owner being online, we label users who are not registered with an "unregistered" label so that it's clear their names are not final yet.

Users should be able to click or tap on this label to see an explanation of what it means. Designs:

https://www.figma.com/file/TV9pF84Ob8pLYRLu83gNol/Joining-when-owner-is-offline?type=design&node-id=311-5980&mode=design&t=zJWpEmDpd1LSWwEO-4

Image

@vinkabuki vinkabuki added this to Quiet Jul 19, 2023
@vinkabuki vinkabuki converted this from a draft issue Jul 19, 2023
@kingalg
Copy link
Collaborator

kingalg commented Aug 1, 2023

@holmesworcester @vinkabuki - could you please provide some designs and more detailed description?

@holmesworcester
Copy link
Contributor

holmesworcester commented Aug 1, 2023

I didn't create this issue so I'm actually not sure what is meant here. I think this was created when we split the epic and it's based on the designs, but because there's no description I don't know what it means :)

We need to add a few lines of issue description even if it seems obvious!

Moving to 'blocked'

UPDATE: I now realize what this is about. Adding details. @kingalg let me know if this is not sufficiently clear.

@holmesworcester holmesworcester moved this from Next Sprint to Blocked in Quiet Aug 1, 2023
@holmesworcester holmesworcester changed the title Explain to user its verification status User should be able to tap/click on "unregistered" label to learn what it means Aug 11, 2023
@holmesworcester holmesworcester moved this from Blocked to Next Sprint in Quiet Aug 11, 2023
@vinkabuki
Copy link
Contributor Author

It was just copy-pasted from #1340, so I also didn't know details.

@Kacper-RF Kacper-RF moved this from Next Sprint to In progress in Quiet Sep 4, 2023
@Kacper-RF Kacper-RF self-assigned this Sep 4, 2023
@Kacper-RF Kacper-RF moved this from In progress to Sprint in Quiet Sep 4, 2023
@Kacper-RF Kacper-RF moved this from Sprint to In progress in Quiet Sep 6, 2023
@Kacper-RF Kacper-RF mentioned this issue Sep 6, 2023
2 tasks
@Kacper-RF Kacper-RF moved this from In progress to Waiting for review in Quiet Sep 11, 2023
@Kacper-RF Kacper-RF moved this from Waiting for review to Merged (develop) in Quiet Sep 12, 2023
@Kacper-RF Kacper-RF moved this from Merged (develop) to Ready for QA in Quiet Sep 14, 2023
@kingalg
Copy link
Collaborator

kingalg commented Sep 21, 2023

Version: 2.0.0-alpha.12
System: Windows, MacOS, Linux

User is able to click on "unregistered" to get details.
Inside popup "OK" and X (close) buttons are working.

Screenshot 2023-09-21 at 11 51 00

Issue can be closed after checking this on mobiles that are not yet ready.

@kingalg kingalg moved this from Ready for QA to (Mobile) Ready for QA in Quiet Sep 21, 2023
@kingalg
Copy link
Collaborator

kingalg commented Oct 17, 2023

[email protected] (iOS 325)
System: android and ios

Button works correctly on mobile devices. I'm not sure about matching design. Is the one on figma intended to cover half of the screen and our implementation is wrong or what we did is correct? @holmesworcester
Our implementation:
Screenshot 2023-10-17 at 12 47 15
Figma design:
Screenshot 2023-10-17 at 12 48 18

@holmesworcester
Copy link
Contributor

holmesworcester commented Oct 17, 2023

The figma version is correct. We have an animated drawer that animates up from the bottom of the screen that we use for settings. It should use this. This should be fixed.

@kingalg
Copy link
Collaborator

kingalg commented Oct 17, 2023

@vinkabuki @Kacper-RF which of you did work on that? Could you take this back and correct it according to figma design? (FYI - buttons are working correctly).

@kingalg kingalg moved this from (Mobile) Ready for QA to Sprint in Quiet Oct 18, 2023
@Kacper-RF
Copy link
Contributor

I'll take care of it

@Kacper-RF Kacper-RF moved this from Sprint to In progress in Quiet Oct 19, 2023
@Kacper-RF Kacper-RF moved this from In progress to Waiting for review in Quiet Oct 19, 2023
@Kacper-RF
Copy link
Contributor

Kacper-RF commented Oct 19, 2023

#1985

EDIT: fixed spacings

Image

@siepra
Copy link
Contributor

siepra commented Oct 19, 2023

This design is bad. It's hard to read, spacings are inconsistent and the button is definitely too small

@Kacper-RF Kacper-RF moved this from Waiting for review to Merged (develop) in Quiet Oct 20, 2023
@Kacper-RF Kacper-RF moved this from Merged (develop) to Ready for QA in Quiet Oct 26, 2023
@kingalg
Copy link
Collaborator

kingalg commented Oct 30, 2023

It's still a little different then in designs - there is a break between sentences. I think that with break it's better but still - not like in designs. Below you can see screen from IOS. @holmesworcester do you accept this version?

2C141478-56CF-4101-A7A5-D3DEB02D1275

@holmesworcester
Copy link
Contributor

Let's stick to the designs. These small things add up.

The two differences I see are the line break and the style of the button.

@kingalg kingalg moved this from Ready for QA to In progress in Quiet Oct 30, 2023
@Kacper-RF Kacper-RF mentioned this issue Oct 31, 2023
4 tasks
@Kacper-RF Kacper-RF moved this from In progress to Merged (develop) in Quiet Nov 6, 2023
@Kacper-RF Kacper-RF moved this from Merged (develop) to Ready for QA in Quiet Nov 8, 2023
@kingalg
Copy link
Collaborator

kingalg commented Nov 16, 2023

[email protected] (iOS 333)

Now it's matching figma design.

@kingalg kingalg closed this as completed Nov 16, 2023
@kingalg kingalg moved this from Ready for QA to Done in Quiet Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

5 participants