-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User should be able to tap/click on "unregistered" label to learn what it means #1649
Comments
@holmesworcester @vinkabuki - could you please provide some designs and more detailed description? |
I didn't create this issue so I'm actually not sure what is meant here. I think this was created when we split the epic and it's based on the designs, but because there's no description I don't know what it means :) We need to add a few lines of issue description even if it seems obvious! Moving to 'blocked' UPDATE: I now realize what this is about. Adding details. @kingalg let me know if this is not sufficiently clear. |
It was just copy-pasted from #1340, so I also didn't know details. |
[email protected] (iOS 325) Button works correctly on mobile devices. I'm not sure about matching design. Is the one on figma intended to cover half of the screen and our implementation is wrong or what we did is correct? @holmesworcester |
The figma version is correct. We have an animated drawer that animates up from the bottom of the screen that we use for settings. It should use this. This should be fixed. |
@vinkabuki @Kacper-RF which of you did work on that? Could you take this back and correct it according to figma design? (FYI - buttons are working correctly). |
I'll take care of it |
EDIT: fixed spacings |
This design is bad. It's hard to read, spacings are inconsistent and the button is definitely too small |
It's still a little different then in designs - there is a break between sentences. I think that with break it's better but still - not like in designs. Below you can see screen from IOS. @holmesworcester do you accept this version? |
Let's stick to the designs. These small things add up. The two differences I see are the line break and the style of the button. |
[email protected] (iOS 333) Now it's matching figma design. |
When we let users join without the community owner being online, we label users who are not registered with an "unregistered" label so that it's clear their names are not final yet.
Users should be able to click or tap on this label to see an explanation of what it means. Designs:
https://www.figma.com/file/TV9pF84Ob8pLYRLu83gNol/Joining-when-owner-is-offline?type=design&node-id=311-5980&mode=design&t=zJWpEmDpd1LSWwEO-4
The text was updated successfully, but these errors were encountered: