Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn user of duplicate unregistered names #1559

Closed
holmesworcester opened this issue Jun 2, 2023 · 3 comments
Closed

Warn user of duplicate unregistered names #1559

holmesworcester opened this issue Jun 2, 2023 · 3 comments
Assignees
Labels

Comments

@holmesworcester
Copy link
Contributor

holmesworcester commented Jun 2, 2023

As part of #1340 we are letting unregistered users send messages. We should use these designs to warn users if an unregistered user has the same name as a registered user or as another unregistered user:

In the message screen, all duplicate usernames should have a "duplicate" warning:

https://www.figma.com/file/TV9pF84Ob8pLYRLu83gNol/Joining-when-owner-is-offline?type=design&node-id=311-7523&mode=design&t=eS9WDLYpQNod1Acl-4

Image

Tapping on this warning should take users to an explanation and warning:

https://www.figma.com/file/TV9pF84Ob8pLYRLu83gNol/Joining-when-owner-is-offline?type=design&node-id=320-2662&mode=design&t=eS9WDLYpQNod1Acl-4

Image

@holmesworcester holmesworcester converted this from a draft issue Jun 2, 2023
@holmesworcester holmesworcester moved this from Sprint to Next sprint in Quiet Jun 15, 2023
@vinkabuki vinkabuki moved this from Next sprint to Sprint in Quiet Jul 19, 2023
@kingalg kingalg changed the title Warn user of duplicate provisional names Warn user of duplicate unregistered names Aug 4, 2023
@kingalg
Copy link
Collaborator

kingalg commented Aug 4, 2023

@holmesworcester this issue is about unregistered user having the same username as registered user. Is it also possible that two unregistered users will have the same names? I can't find issue for this and I was thinking if this is technically possible or not?

@holmesworcester
Copy link
Contributor Author

holmesworcester commented Aug 4, 2023

Multiple unregistered users having the same name can be handled with the same warning as registered/unregistered. This issue covers both cases.

@Kacper-RF Kacper-RF moved this from Next Sprint to In progress in Quiet Sep 4, 2023
@Kacper-RF Kacper-RF self-assigned this Sep 4, 2023
@Kacper-RF Kacper-RF mentioned this issue Sep 6, 2023
2 tasks
@Kacper-RF Kacper-RF moved this from In progress to Waiting for review in Quiet Sep 11, 2023
@Kacper-RF Kacper-RF moved this from Waiting for review to Merged (develop) in Quiet Sep 12, 2023
@Kacper-RF Kacper-RF moved this from Merged (develop) to Ready for QA in Quiet Sep 14, 2023
@kingalg
Copy link
Collaborator

kingalg commented Oct 30, 2023

[email protected]

Done on Desktop and Mobile. All issues discovered in this area has been reported in separate github issues.

@kingalg kingalg closed this as completed Oct 30, 2023
@kingalg kingalg moved this from Ready for QA to Done in Quiet Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

3 participants