Update to bevy 0.14.0 #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trouv
added a commit
that referenced
this pull request
Jul 8, 2024
…a git branch patch (#326) Closes #321 Currently, we're using a patch to depend on `bevy_ecs_tilemap`. This places a burden on the user to use a similar patch in their own `Cargo.toml`. We're also using the `main` branch of `bevy_ecs_tilemap` in this patch. This can lead to issues when updates occur to that branch of the `bevy_ecs_tilemap` repository, as new users and `cargo update`rs will pull in any new changes to that repo, even breaking ones. This is currently affecting our CI. This PR's changes will ultimately be overwritten soon by an update to bevy 0.14 (#325), but merging this sooner will help set the standard for development of this project inbetween `bevy_ecs_tilemap` releases in the future, and also unblock other PRs whose CI checks are affected (#306).
Trouv
reviewed
Jul 19, 2024
There was a problem hiding this comment.
Here's a few extra things that there isn't a great place to put a comment for:
- unfortunately, the mdbook CI check produces false positives, but it's failing here (a couple code snippets in
tutorials/tile-based-game/spawn-your-ldtk-project-in-bevy.mdneed to be updated): https://github.com/Trouv/bevy_ecs_ldtk/actions/runs/9999446181/job/27640460200?pr=325#step:7:586 - a new 0.14 mdbook migration guide chapter for breaking changes introduced here would be much appreciated, but I can do it in a follow-up PR if its too difficult to try to follow the format of previous migration guide chapters
- macro changes
- LdtkSpriteSheetBundle vs SpriteSheetBundle
- Update compatibility chart in README.md (map
mainofbevy_ecs_ldtkto bevy 0.14/ bevy_ecs_tilemap 0.14)
I still have yet to try out the examples
|
Added a migration guide but I wasn't quite sure how to frame it. I set it up as a 0.9 to 0.10 guide, but I'm not sure if that's what you'd want. I can change it if you wish |
Trouv
approved these changes
Jul 20, 2024
|
Ported one of my games from Bevy 0.12.1 to 0.14 and this branch worked flawlessly. |
This was referenced Jul 20, 2024
Closed
Trouv
added a commit
that referenced
this pull request
Jul 20, 2024
🤖 I have created a release *beep* *boop* --- ## [0.10.0](v0.9.0...v0.10.0) (2024-07-20) ### ⚠ BREAKING CHANGES * upgrade to bevy and bevy_ecs_ldtk 0.14 ([#325](#325)) * upgrade to bevy 0.13 ([#302](#302)) ### Features * add #[default] attribute to LdtkEntity and LdtkIntCell derive macros ([#306](#306)) ([416a46e](416a46e)) * upgrade to bevy 0.13 ([#302](#302)) ([2ee602f](2ee602f)), closes [#301](#301) * upgrade to bevy and bevy_ecs_ldtk 0.14 ([#325](#325)) ([d888535](d888535)) ### Documentation Changes * remove unused AssetServer param in *Game logic integration* chapter ([#318](#318)) ([617b108](617b108)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #324
Basic support for 0.14, tested on 0.14.0-rc.4.
CI passes, but there's probably extraneous casting.
Bevy 0.14 deprecates
SpriteSheetBundle, saying to just add a texture atlas to a sprite bundle, so I recreated it asLdtkSpriteSheetBundle