Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage help for Bevy 0.13 users #321

Closed
icorbrey opened this issue May 14, 2024 · 3 comments · Fixed by #326
Closed

Usage help for Bevy 0.13 users #321

icorbrey opened this issue May 14, 2024 · 3 comments · Fixed by #326

Comments

@icorbrey
Copy link

You will likely be running into a host of problems attempting to use this plugin with Bevy 0.13 as bevy_ecs_tilemap has not yet released changes to support 0.13 (see StarArawn/bevy_ecs_tilemap#516). To resolve this, add the following to your Cargo.toml:

[dependencies]
# Use unstable version for Bevy 0.13 support
bevy_ecs_ldtk = { git = "https://github.com/Trouv/bevy_ecs_ldtk.git" } 

[patch.crates-io]
# Patch unstable version to resolve conflicting dependencies from bevy_ecs_ldtk
bevy_ecs_tilemap = { git = "https://github.com/StarArawn/bevy_ecs_tilemap" }

@Trouv feel free to close this if you deem so, but I thought it would be helpful for new users trying to figure this out.

@Trouv Trouv pinned this issue May 15, 2024
@haath
Copy link

haath commented Jun 5, 2024

This does work, but I'd argue that it shouldn't be necessary.

Versions of bevy_ecs_ldtk that claim in the README to track the main branch of bevy_ecs_tilemap, should just have bevy_ecs_tilemap as a git dependency in the Cargo.toml. Ideally also pinned to exact commit that was last tested.

Otherwise this repo is essentially in an invalid state.

@Trouv
Copy link
Owner

Trouv commented Jun 6, 2024

Yeah I agree somewhat. Next time we end up in this in-between state I do plan to add it as a git dependency rather than a patch, and will probably do a pre-release on crates.io as well. I intend to do it for the current version too but haven't gotten around to it.

@haath
Copy link

haath commented Jun 6, 2024

I believe that crates.io doesn't allow crates with unpublished dependencies. cargo#6738
And it does make sense, if that were possible then any crate could break unpredictably.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants