From 773cdc31ef3e17327d1eb0a3b92828e25457f015 Mon Sep 17 00:00:00 2001
From: Rich Trott <rtrott@gmail.com>
Date: Sat, 28 Jan 2017 21:47:14 -0800
Subject: [PATCH] test: increase strictness for test-trace-event

Change test-trace-event such that it checks that all expected values are
within the same trace object rather than scattered across multiple trace
objects.

PR-URL: https://github.com/nodejs/node/pull/11065
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
---
 test/parallel/test-trace-event.js | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/test/parallel/test-trace-event.js b/test/parallel/test-trace-event.js
index 18734705834407..fde718d7bc06fb 100644
--- a/test/parallel/test-trace-event.js
+++ b/test/parallel/test-trace-event.js
@@ -21,15 +21,19 @@ proc_no_categories.once('exit', common.mustCall(() => {
 
   proc.once('exit', common.mustCall(() => {
     assert(common.fileExists(FILE_NAME));
-    fs.readFile(FILE_NAME, (err, data) => {
+    fs.readFile(FILE_NAME, common.mustCall((err, data) => {
       const traces = JSON.parse(data.toString()).traceEvents;
       assert(traces.length > 0);
       // Values that should be present on all runs to approximate correctness.
-      assert(traces.some((trace) => { return trace.pid === proc.pid; }));
-      assert(traces.some((trace) => { return trace.cat === 'v8'; }));
       assert(traces.some((trace) => {
-        return trace.name === 'V8.ScriptCompiler';
+        if (trace.pid !== proc.pid)
+          return false;
+        if (trace.cat !== 'v8')
+          return false;
+        if (trace.name !== 'V8.ScriptCompiler')
+          return false;
+        return true;
       }));
-    });
+    }));
   }));
 }));