Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent certain operations on collections when using different sessions and/or schemas #50

Closed
5 tasks
rkoschmitzky opened this issue Jul 4, 2023 · 0 comments · Fixed by #51
Closed
5 tasks

prevent certain operations on collections when using different sessions and/or schemas #50

rkoschmitzky opened this issue Jul 4, 2023 · 0 comments · Fixed by #51
Assignees
@rkoschmitzky
Labels
bug Something isn't working enhancement New feature or request
Milestone
v0.1.0rc5

Comments

@rkoschmitzky
Copy link
Contributor

rkoschmitzky commented Jul 4, 2023 •
edited
Loading

Goal

Certain operations should be prevented between collections if those are using different session objects and/or schemas.

Motivation

As each session maintains its own cache we need to prevent the creation of collections that are based on different sessions. The same is true for different user-provided schemas, as these are driving the attribute resolution.

The following methods need to consider a check:

  • __setattr__ (also used by apply)
  • union
  • difference
  • symmetric_difference
  • intersection
@rkoschmitzky rkoschmitzky added the enhancement New feature or request label Jul 4, 2023
@rkoschmitzky rkoschmitzky added this to the v0.1.0rc5 milestone Jul 4, 2023
@rkoschmitzky rkoschmitzky self-assigned this Jul 4, 2023
@rkoschmitzky rkoschmitzky added the bug Something isn't working label Jul 4, 2023
@rkoschmitzky rkoschmitzky changed the title prevent set operations on collections using different sessions and schemas prevent certain operations on collections using different sessions and/or schemas Jul 4, 2023
@rkoschmitzky rkoschmitzky linked a pull request Jul 4, 2023 that will close this issue
verify operations can be performed between collections #51
Merged
5 tasks
@rkoschmitzky rkoschmitzky changed the title prevent certain operations on collections using different sessions and/or schemas prevent certain operations on collections when using different sessions and/or schemas Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rkoschmitzky rkoschmitzky

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
v0.1.0rc5
Development

Successfully merging a pull request may close this issue.

verify operations can be performed between collections TrixterFilm/trackteroid
1 participant
@rkoschmitzky