Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doesn't work with testCoverageEnabled true #498

Closed
MHPtweidinger opened this issue Jan 17, 2019 · 9 comments
Closed

doesn't work with testCoverageEnabled true #498

MHPtweidinger opened this issue Jan 17, 2019 · 9 comments

Comments

@MHPtweidinger
Copy link

First of all, thank you for the nice plugin. Today, unfortunately we just discovered a potential bug. If you set testCoverageEnabled true in the release flavor of the app, the plugin doesn't work anymore and doesn't throw an error. Is there something we can do about this?

@SUPERCILEX
Copy link
Collaborator

What's the error?

@MHPtweidinger
Copy link
Author

there is no error in terms of an exception. the task execution for gradle publish simply does nothing and finishes within 1 second.
also tasks like gradle publishRelease are not available anymore when we activate testCiverage on the release buildType.

@SUPERCILEX
Copy link
Collaborator

@MHPtweidinger
Copy link
Author

okay, didn't know that. thanks for the heads up. but some sort of log entry or exception would be nice and might safe others hours of investigation, like it took us today to find the root cause of the plugin not working anymore. but still, nice plugin. we appreciate it.

@SUPERCILEX
Copy link
Collaborator

We do log it at the info level (so you'd have to run ./gradlew ... --info). We can't change that otherwise all debug builds would be logging warnings. 😢

@SUPERCILEX
Copy link
Collaborator

Actually, you know what!? We can check to see if the name contains "release" and log it as a warning then. Doing that rn.

@SUPERCILEX
Copy link
Collaborator

Done: #500

@MHPtweidinger
Copy link
Author

yeah, thanks. and congrats on the 500th pull request ;)

@SUPERCILEX
Copy link
Collaborator

Hehe, thanks 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants