Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrader goes throw all upgrade stages on each Tribler's run #7381

Closed
drew2a opened this issue Apr 21, 2023 · 1 comment
Closed

Upgrader goes throw all upgrade stages on each Tribler's run #7381

drew2a opened this issue Apr 21, 2023 · 1 comment

Comments

@drew2a
Copy link
Contributor

drew2a commented Apr 21, 2023

The current implementation of the upgrader goes throw all upgrade stages regardless of whether or not it is actually needed.

Instead of (current version):

[tribler-gui PID:33165] 2023-04-21 15:30:17,516 - INFO - UpgradeManager(183) - Start upgrade process
[tribler-gui PID:33165] 2023-04-21 15:30:17,516 - INFO - UpgradeManager(147) - Should cleanup old versions
[tribler-gui PID:33165] 2023-04-21 15:30:17,516 - INFO - UpgradeManager(150) - Last run version is the same as the current version. Exit cleanup procedure.
[tribler-gui PID:33165] 2023-04-21 15:30:17,517 - INFO - StateDirUpgradeWorker(46) - Run
[tribler-gui PID:33165] 2023-04-21 15:30:17,518 - INFO - StateDirUpgradeWorker(61) - Upgrade state dir for <VersionHistory[(7, 13), (7, 10), (7, 12)]>
[tribler-gui PID:33165] 2023-04-21 15:30:17,518 - INFO - VersionHistory(346) - State directory should not be copied
[tribler-gui PID:33165] 2023-04-21 15:30:17,518 - INFO - Tribler Config(100) - Load: /Users/drew2a/.Tribler/7.13/triblerd.conf. State dir: /Users/drew2a/.Tribler/7.13. Reset config on error: True
[tribler-gui PID:33165] 2023-04-21 15:30:17,521 - INFO - Tribler Config(86) - Init. State dir: None. File: None
[tribler-gui PID:33165] 2023-04-21 15:30:17,523 - INFO - TriblerUpgrader(95) - Run
[tribler-gui PID:33165] 2023-04-21 15:30:17,523 - INFO - TriblerUpgrader(377) - Upgrading GigaChannel DB from version 8 to 10
[tribler-gui PID:33165] 2023-04-21 15:30:17,530 - INFO - TriblerUpgrader(197) - Upgrade Pony DB 10 to 11
[tribler-gui PID:33165] 2023-04-21 15:30:17,543 - INFO - tribler.core.upgrade.config_converter(12) - Upgrade config to 7.6
[tribler-gui PID:33165] 2023-04-21 15:30:17,544 - INFO - TriblerUpgrader(213) - Upgrade bandwidth accounting DB 8 to 9
[tribler-gui PID:33165] 2023-04-21 15:30:17,547 - INFO - TriblerUpgrader(181) - Upgrade Pony DB 11 to 12
[tribler-gui PID:33165] 2023-04-21 15:30:17,564 - INFO - TriblerUpgrader(166) - Upgrade Pony DB 12 to 13
[tribler-gui PID:33165] 2023-04-21 15:30:17,580 - INFO - TriblerUpgrader(146) - Upgrade Pony DB from version 13 to version 14
[tribler-gui PID:33165] 2023-04-21 15:30:17,608 - INFO - TriblerUpgrader(130) - Upgrade tags to knowledge
[tribler-gui PID:33165] 2023-04-21 15:30:17,609 - INFO - MigrationTagsToKnowledge(29) - Tags DB path: /Users/drew2a/.Tribler/7.13/sqlite/tags.db
[tribler-gui PID:33165] 2023-04-21 15:30:17,609 - INFO - MigrationTagsToKnowledge(30) - Knowledge DB path: /Users/drew2a/.Tribler/7.13/sqlite/knowledge.db
[tribler-gui PID:33165] 2023-04-21 15:30:17,610 - INFO - MigrationTagsToKnowledge(33) - Starting upgrade procedure for tags DB
[tribler-gui PID:33165] 2023-04-21 15:30:17,610 - INFO - MigrationTagsToKnowledge(36) - Tags DB doesn't exist. Stop procedure.
[tribler-gui PID:33165] 2023-04-21 15:30:17,610 - INFO - TriblerUpgrader(109) - Remove old logs
[tribler-gui PID:33165] 2023-04-21 15:30:17,615 - INFO - TriblerUpgrader(135) - Upgrade Pony DB from version 14 to version 15
[tribler-gui PID:33165] 2023-04-21 15:30:17,636 - INFO - StateDirUpgradeWorker(56) - Finished

it should be:

[tribler-gui PID:33165] 2023-04-21 15:30:17,516 - INFO - UpgradeManager(183) - Start upgrade process
[tribler-gui PID:33165] 2023-04-21 15:30:17,516 - INFO - UpgradeManager(150) - Last run version is the same as the current version. Exit upgrade procedure.
@drew2a drew2a added this to the 7.14.0 milestone Apr 21, 2023
@drew2a drew2a modified the milestones: 7.14.0, 7.13.0 May 1, 2023
@drew2a drew2a self-assigned this May 1, 2023
@drew2a drew2a removed their assignment May 3, 2023
@drew2a drew2a removed this from the 7.13.0 milestone May 3, 2023
@drew2a
Copy link
Contributor Author

drew2a commented Nov 27, 2023

This issue was addressed in #7622

@drew2a drew2a closed this as completed Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant