Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistency: spaces around {nl} #962

Open
Soukyuu opened this issue Sep 1, 2015 · 7 comments
Open

Consistency: spaces around {nl} #962

Soukyuu opened this issue Sep 1, 2015 · 7 comments

Comments

@Soukyuu
Copy link
Contributor

Soukyuu commented Sep 1, 2015

Going through the files, I notice that the spaces around {nl} vary from line to line.
For example there are lines where there is no space after the period, but there is a space afterwards, even though that would mean that there will be a space on the new line before the sentence starts. For other sentences, there is a space before and after the {nl}. This is not limited to English files, but also Korean originals.

Is there a rule on that already? I couldn't find one. Personally, I'd want to establish the following rule:

  • no space before {nl}: there is no reason to have a trailing space
  • no space after {nl}: the first letter should be the first character of a new line, else we waste 1 character per line

An example line: There are some stories about Lydia Schaffen.{nl}According to them, she was quite an oddball.

@vtange
Copy link
Contributor

vtange commented Sep 2, 2015

IIRC, the spaces actually didn't matter when it came to the game reading the lines. {nl}[space]Start of line didn't cause any issues with lines being rendered in game out of place or anything. I literally checked this during my time in iCBT using the real-time-translator.

Right now, I just leave everything as is and not worry about it unless the space is within the brackets. I'd rather work being put in actually translating things instead of worrying about small detail stuff that you can't even see the effect of in-game.

@Soukyuu
Copy link
Contributor Author

Soukyuu commented Sep 2, 2015

So you're saying the game is stripping the trailing and preceding spaces automatically? If that's the case, then I guess it's a non-issue.

@Soukyuu
Copy link
Contributor Author

Soukyuu commented Oct 4, 2015

I've seen a couple of lines have different linebreaks when using [space]{nl}, so we should take care to not have a space before the {nl} tag.

@darkmiz
Copy link

darkmiz commented Nov 11, 2015

why do the korean files add {nl} in the beginning and end of some lines?
I believe they are typos, we should just delete them when translating.

example: QUEST_LV_0200_kor.tsv

QUEST_LV_0200_20150317_000056 정말 고맙군.{nl}괜찮다면, 자네의 힘을 좀 더 빌리고 싶네.{nl}
QUEST_LV_0200_20150317_000100 {nl}나도 그럼 이쪽에서 뭐라도 해야겠지.{nl}우선은 붉은 부베 약탈자를 좀 처리해 줘. 거슬리기 짝이 없거든.

@ttgmichael
Copy link
Contributor

Actually, not all lines correspond to a separate dialogue. Some lines from the files are concatenated with another line. Hence, the {nl}'s in front are necessary. They are not typos.

Hope this helps :)

@darkmiz
Copy link

darkmiz commented Nov 11, 2015

I thought one line corresponds to one dialogue box? Can someone confirm this?

@Soukyuu
Copy link
Contributor Author

Soukyuu commented Nov 13, 2015

There are, in fact, some dialogues that span multiple lines. I don't have an example, but I've worked with a few such lines already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants