Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Types in Published NPM Module #10

Open
icereval opened this issue Jul 2, 2020 · 4 comments
Open

Missing Types in Published NPM Module #10

icereval opened this issue Jul 2, 2020 · 4 comments

Comments

@icereval
Copy link

icereval commented Jul 2, 2020

FYI, the published npm module as of v0.1.28 does not include the generated type definition file in dist/index.d.ts.

Thanks for taking the time to publish this nifty utility!

@TreeMan360
Copy link
Owner

Thanks for reporting this, I will ensure this is resolved in the next few days.

@jpwilliams
Copy link

Bump to get this in!

I was going to submit a PR as I assumed it was a build issue but the types are definitely generated fine in the dist folder, just weren't pushed with the package.

Thanks loads for this lib though. I've done much more bare-bones GraphQL projects previously and used dataloader directly, but was a bit nervous about exactly this issue when I saw that NestJS didn't have anything set up for it!

@jared-fraser
Copy link

@TreeMan360 any chance we can get these types packaged in?

cheers

@holm
Copy link
Contributor

holm commented Feb 8, 2021

Would be really nice to get the types published. Makes it a lot easier to work with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants