Skip to content
This repository has been archived by the owner on Oct 19, 2023. It is now read-only.

Could we separate the renderHeader for the bool and function? #25

Open
gabrielbull opened this issue Mar 23, 2018 · 6 comments
Open

Could we separate the renderHeader for the bool and function? #25

gabrielbull opened this issue Mar 23, 2018 · 6 comments

Comments

@gabrielbull
Copy link

renderHeader: oneOfType([bool, func]),

I think it would be more explicit if there was a different property for rendering the default header and renderHeader. The common way would be to have a prop header for the boolean and the renderHeader prop handle the render header function. We could also have a HeaderComponent prop to pass a component as the header.

So we would potentially have 3 properties to pass the header:

    header: bool,
    renderHeader: func,
    HeaderComponent: node
@Traviskn
Copy link
Owner

I think this is a good idea! My implementation of the header is still incomplete. I am working on it on the header branch and am getting closer to having a working implementation

@gabrielbull
Copy link
Author

gabrielbull commented Mar 23, 2018

I figured, I'm here to help. I'm using your header branch with some changes to re-create the same header as Apple has in the settings app, with the multiple animations (fade in/out on back button, translation/color change of header to become the back button, etc)

ezgif com-video-to-gif

Pretty cool stuff what we can do with this header branch.

@Traviskn
Copy link
Owner

Nice! I appreciate the help 😄

@nicollecastrog
Copy link
Contributor

@Traviskn @gabrielbull I love ❤️ this module! I'm really keen to get the header branch into a proper master state so I we can use it for our project at work. How can I help? Is there a to-do list somewhere of what's missing?

Thanks!

@Traviskn
Copy link
Owner

Unfortunately I haven't had much time to work on this module 😞
I'm not sure if I will have time to get my header branch into a working state, but I'd be open to any PRs that implement header transitions!

@nicollecastrog
Copy link
Contributor

@Traviskn Life happens, no worries! Here's my take on header/footer transitions: #35 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants