-
Notifications
You must be signed in to change notification settings - Fork 36
Could we separate the renderHeader for the bool and function? #25
Comments
I think this is a good idea! My implementation of the header is still incomplete. I am working on it on the |
I figured, I'm here to help. I'm using your header branch with some changes to re-create the same header as Apple has in the settings app, with the multiple animations (fade in/out on back button, translation/color change of header to become the back button, etc) Pretty cool stuff what we can do with this header branch. |
Nice! I appreciate the help 😄 |
@Traviskn @gabrielbull I love ❤️ this module! I'm really keen to get the Thanks! |
Unfortunately I haven't had much time to work on this module 😞 |
react-router-native-stack/lib/Stack.js
Line 15 in c6a0e3a
I think it would be more explicit if there was a different property for rendering the default header and renderHeader. The common way would be to have a prop
header
for the boolean and therenderHeader
prop handle the render header function. We could also have aHeaderComponent
prop to pass a component as the header.header
prop as a booleanrenderHeader
prop as a functionHeaderComponent
prop as nodeSo we would potentially have 3 properties to pass the header:
The text was updated successfully, but these errors were encountered: