-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checkins with a delay are sorted wrong #1382
Comments
This is our current query for the private dashboard: traewelling/app/Http/Controllers/Backend/User/DashboardController.php Lines 19 to 37 in 74d3a98
We sort here only according to the planned departure of the Journey:
In order for us to aggregate the data correctly directly we would need to do the following sorts in order:
Since our data structure is a bit complex to build a meaningful and performant query for it I would suggest to do the sorting only on the frontend level so that it looks properly sorted to the user. |
Describe the bug
If e.g. I checkin in a train which derparting at 7am and I get on a train departing 6:30am but has 1 hour delay, the delayed checkin is sorted under the first checkin.
It also happens on the Global Dashboard and Home Dashboard that it's sorted wrong
To Reproduce
Steps to reproduce the behavior:
Expected behavior
That the Page sorts the Checkins with the delayed departure time not only the sheduled departure time.
Screenshots
If applicable, add screenshots to help explain your problem.
See how its sorted: (Deleted some fields for privacy reason)
Desktop (please complete the following information):
Any Browser
Smartphone (please complete the following information):
Any Smartphone
The text was updated successfully, but these errors were encountered: