Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Huge FPS drop when loading head models from Cataclysm #302

Open
Jaimarl opened this issue Dec 13, 2024 · 4 comments
Open

[Bug] Huge FPS drop when loading head models from Cataclysm #302

Jaimarl opened this issue Dec 13, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@Jaimarl
Copy link

Jaimarl commented Dec 13, 2024

Describe the bug
When loading head models from Cataclysm, the FPS drops very badly. Happens after every reloading of resources. Logs:

[08:54:10] [Render thread/WARN] [EMF/]: [EMF]: model attempted creation more than 500 times {cataclysm:kobolediator_head_model#main]. EMF is now ignoring this model.
[08:54:10] [Render thread/WARN] [EMF/]: [EMF]: model attempted creation more than 500 times {cataclysm:aptrgangr_head_model#main]. EMF is now ignoring this model.
[08:54:10] [Render thread/WARN] [EMF/]: [EMF]: model attempted creation more than 500 times {cataclysm:draugr_head_model#main]. EMF is now ignoring this model.

To Reproduce
Steps to reproduce the behavior:

  1. See item models in any gui

(please complete the following information):

  • Minecraft Version: 1.20.1
  • EMF version 2.2.6
@Jaimarl Jaimarl added the bug Something isn't working label Dec 13, 2024
@Traben-0
Copy link
Owner

Traben-0 commented Dec 13, 2024

does the fps return to normal after these couple of message first appear?

it seems the mod's models are not being created in an efficient way and are being recreated every frame

emf will detect this and start ignoring them after 500 frames of this, which can be possibly a bit laggy, but afterwards should return to normal

@Traben-0
Copy link
Owner

I could look into lowering the cutoff to be less than 500 attempts, but that mod should really not be recreating the model every frame thats very unnessecary

@Jaimarl
Copy link
Author

Jaimarl commented Dec 13, 2024

FPS drops for a couple seconds and then goes back to normal. Is there any blacklist where I can add these models?

@Traben-0
Copy link
Owner

you can disable the models in the emf > models > allmodels > modelname settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants