Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify conversion check #7220

Merged
merged 3 commits into from
Nov 25, 2024
Merged

simplify conversion check #7220

merged 3 commits into from
Nov 25, 2024

Conversation

mslabek
Copy link
Member

@mslabek mslabek commented Nov 22, 2024

Describe your changes

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@Diamekod0221 Diamekod0221 merged commit 6716c23 into fix_subtyping_in_DictService Nov 25, 2024
1 check passed
@Diamekod0221 Diamekod0221 deleted the poc-try-to-simplify-conversion-check branch November 25, 2024 17:49
Diamekod0221 pushed a commit that referenced this pull request Nov 26, 2024
@mslabek
simplify conversion check (#7220)
4b3a818 
* simplify conversion check

* changes to TypeConversionHandler

* test fixes

---------

Co-authored-by: Marcel Philipiak <[email protected]>
Diamekod0221 pushed a commit that referenced this pull request Nov 27, 2024
@mslabek
simplify conversion check (#7220)
32f8eb0 
* simplify conversion check

* changes to TypeConversionHandler

* test fixes

---------

Co-authored-by: Marcel Philipiak <[email protected]>
Diamekod0221 pushed a commit that referenced this pull request Nov 28, 2024
@mslabek
simplify conversion check (#7220)
2be5f30 
* simplify conversion check

* changes to TypeConversionHandler

* test fixes

---------

Co-authored-by: Marcel Philipiak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mslabek @Diamekod0221