Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test::radio::simulate_connection_event_response() does not take acknowledge correctly into account #134

Open
TorstenRobitzki opened this issue Sep 25, 2023 · 1 comment
Open

test::radio::simulate_connection_event_response() does not take acknowledge correctly into account #134

TorstenRobitzki opened this issue Sep 25, 2023 · 1 comment
Labels
bug enhancement

Comments

@TorstenRobitzki
Copy link
Owner

It's possible to set any SN or NSN in the simulated received PDUs, the result will be the same. To test correct behavior for the acknowledge scheme on a higher layer, it would be useful, if the test radio, also resends unacknowledged data.

(it's possible to comment out the content of unconnected_base_t<>::next_sequences() without breaking any test).
@TorstenRobitzki
Copy link
Owner Author

LL/CON/PER/BI-02-C in ll_control_tests.cpp might be simplified when this is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TorstenRobitzki