Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read #5

Closed
2 tasks done
TornaxO7 opened this issue Aug 21, 2021 · 8 comments · Fixed by #11
Closed
2 tasks done

Read #5

TornaxO7 opened this issue Aug 21, 2021 · 8 comments · Fixed by #11
Assignees

Comments

@TornaxO7
Copy link
Owner

TornaxO7 commented Aug 21, 2021

  • The JSON output does not have the same shape (it misses hasAttachment)
  • The JSOn output should show the text/html version of the mail if no text/plain is found.
@TornaxO7 TornaxO7 added this to the Msg refactoring milestone Aug 21, 2021
@TornaxO7
Copy link
Owner Author

@soywod Have you started to work on these two issues yet? If not, should I pick one? And can you create a PR-Draft for this issue please for the kanban board?

@soywod
Copy link
Collaborator

soywod commented Aug 21, 2021

I did not start yet, you can take both if you have time! Because I will work on the refactor as mentioned there #9 (comment).

@TornaxO7
Copy link
Owner Author

Alright, then I'll take over those two issues!

@TornaxO7 TornaxO7 assigned TornaxO7 and unassigned soywod Aug 21, 2021
@TornaxO7
Copy link
Owner Author

@soywod I've got a question for the first task: Isn't it possible to create a key attachments for each message. So everyone just needs to look if the length of this list is greater than 0 to know if there are attachments or not.

@soywod
Copy link
Collaborator

soywod commented Aug 22, 2021

Initially, I did not put the attachments for all messages because of perfs. To get informations about attachments you need to parse bodies, which implies a bigger IMAP request and longer parsing time. What could fix this is a caching system, but as I already explained this will move to a dedicated lib (see pimalaya#118 (reply in thread)).

@TornaxO7
Copy link
Owner Author

Hold on. My fork here get's everything of a message, that also means all attachments of a message. Is this fine?

@soywod
Copy link
Collaborator

soywod commented Aug 22, 2021

Well, we will see by usage. If it's too slow to show the message list, we will remove it!

@TornaxO7 TornaxO7 linked a pull request Aug 22, 2021 that will close this issue
@TornaxO7
Copy link
Owner Author

TornaxO7 commented Aug 26, 2021

Closed due to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants