Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Craft 3 support? #2

Closed
jalendport opened this issue Oct 19, 2018 · 2 comments
Closed

Craft 3 support? #2

jalendport opened this issue Oct 19, 2018 · 2 comments
Assignees

Comments

@jalendport
Copy link

Created by Jon Heller (@jon-heller) on 05/30/18

I know this plugin is listed under Craft 3 plugins (and has it in the repo title), but we ran into some issues i.e. calling Craft::$app->getConfig()->maxPowerCaptain(); instead of \craft\Helpers\App::maxPowerCaptain();.

We also got an error using the example

./craft walk entries --section=blog --limit=null elements.saveElement

Calling [elements.saveElement] on each Entry.Exception 'TypeError' with message 'Argument 3 passed to craft\services\Elements::saveElement() must be of the type boolean, null given'

Thank you!

@jalendport
Copy link
Author

Posted by Michael Rog (@michaelrog) on 06/02/18

Thanks Jon! Feel free to PR fixes for this to the dev branch if you can, or I'll take a look as soon as possible.

@michaelrog
Copy link
Member

Craft method calls have been updated (#4), and I've split the userdata TypeError into another issue (#5). Thanks @jon-heller for calling these issues to our attention. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants