Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken by V8 6.0 (Node 8.3.0+) #83

Closed
MylesBorins opened this issue Aug 10, 2017 · 1 comment
Closed

Broken by V8 6.0 (Node 8.3.0+) #83

MylesBorins opened this issue Aug 10, 2017 · 1 comment

Comments

@MylesBorins
Copy link

It would appear that there are changes to garbage collection, which makes a bunch of sense.

Will dig back into this soon

  1) Object should retain references to written Objects:

      AssertionError [ERR_ASSERTION]: "o" has not been garbage collected
      + expected - actual

      -false
      +true

      at Context.<anonymous> (test/object.js:46:5)

  2) pointer should retain references to a written pointer in a Buffer:

      AssertionError [ERR_ASSERTION]: "child" has not been garbage collected
      + expected - actual

      -false
      +true

      at Context.<anonymous> (test/pointer.js:45:5)
@TooTallNate
Copy link
Owner

Fixed by #85.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants