Skip to content
This repository has been archived by the owner on May 5, 2023. It is now read-only.

Update request agent-base #51

Closed
seiya-git opened this issue Dec 11, 2019 · 12 comments · Fixed by #55
Closed

Update request agent-base #51

seiya-git opened this issue Dec 11, 2019 · 12 comments · Fixed by #55

Comments

@seiya-git
Copy link

seiya-git commented Dec 11, 2019

Please update agent-base dependency in package.json
ref: TooTallNate/node-agent-base#35

@seiya-git seiya-git changed the title Update request Update request agent-base Dec 11, 2019
@seiya-git
Copy link
Author

@TooTallNate ping?

@JasonZigelbaum
Copy link

@TooTallNate is it possible to get an update on this? It's causing issues for anyone using this package (or a package using this package) with the same severity as: TooTallNate/node-agent-base#35. Thanks!

@ghost
Copy link

ghost commented Feb 29, 2020

We very much need this updated so we can get around TooTallNate/node-agent-base#35

@artem-karpenko
Copy link

Need this very much, in particular this makes got requests fail when node-proxy-agent is indirectly required. Any update, @TooTallNate?

@magicdawn
Copy link

ping @TooTallNate again, +1 on got proxy issues.

@boisei0
Copy link

boisei0 commented May 12, 2020

Additonally, when updating please release this as minor release rather than a major like happened with agent-base itself. Any attempts at using got in integrations in other projects that might have other integrations depending somewhere on any of the proxy-agents, makes it impossible to use https URLs because of the patching in v4 of agent-base.
another ping for @TooTallNate

@apexad
Copy link

apexad commented May 20, 2020

Need this too!
Please @TooTallNate

@vnenkpet
Copy link

Google Cloud suddenly probably changed its nodejs10 runtime and this became an issue for us using got. I can't find a proper solution for this.

@santiago-perez-axa
Copy link

I also got the same problem with got versions >=10

@vnenkpet
Copy link

vnenkpet commented May 22, 2020

Just a tip for anyone who needs to solve this - try running npm ls agent-node and see which dependencies require the old version. For me it was the mailgun-js package so I fixed my problem by removing it and implementing Mailgun API client myself.

@fishsaidno
Copy link

+1

└─┬ [email protected]
  └─┬ [email protected]
    ├── [email protected]           <---
    ├─┬ [email protected]
    │ └── [email protected]         <---
    ├─┬ [email protected]
    │ └── [email protected]         <---
    ├─┬ [email protected]
    │ └── [email protected]         <---
    └─┬ [email protected]
      └── [email protected]         <---

@alvis
Copy link

alvis commented Sep 4, 2020

ping @TooTallNate
Sorry to bother, but the outdated dependency on socks-proxy-agent is causing problems on us.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants