Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delayed audio generated from Tone.Offline #554

Closed
jasoncslaughter opened this issue Oct 8, 2019 · 4 comments
Closed

Delayed audio generated from Tone.Offline #554

jasoncslaughter opened this issue Oct 8, 2019 · 4 comments

Comments

@jasoncslaughter
Copy link

I am having an issue when using Tone.Offline. I am able to generate a buffer and then play the buffer just fine... I am also using console.log to confirm that the notes that I am playing from a sequence are being triggered at the correct time.

However, when listening to the audio, I hear one note at the beginning, then no notes for 50% of the rendered time, then at the 50% point you will be able to hear the sequence.

here is a link to a demo: https://jsfiddle.net/y8ksn5hb/6/ (please wait a few seconds for the audio to generate... Or look for the 'buffer complete' message in the console.log).

I am following very closely what is in the demo (https://tonejs.github.io/examples/offline.html), so I believe there might be a bug.

@tambien
Copy link
Contributor

tambien commented Oct 8, 2019

I wonder if it's related to #551. i've modified your code seems to work ok running on the typescript branch, but the API is slightly different: https://jsfiddle.net/yotammann/nreh1uz2/

@jasoncslaughter
Copy link
Author

Cool, yeah the typescript branch seems to work. Am I correct in assuming that the typescript will be merged into the main branch sometime in the future, and the API changes are the "correct" way to do things going forward? Is the typescript branch fairly stable?

@tambien
Copy link
Contributor

tambien commented Oct 9, 2019

The typescript API will eventually be merged into dev and then master, so this is the API going forward. I'd say it's somewhat stable but still missing a number of effects and synths at this point which are being added regularly. If you're feeling adventurous, give it a shot!

@tambien
Copy link
Contributor

tambien commented Nov 13, 2019

I'm going to close this and track this issue just in #551.

@tambien tambien closed this as completed Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants