Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Privatize callable public functions used for signals #194

Closed
TokisanGames opened this issue Aug 28, 2023 · 2 comments
Closed

Privatize callable public functions used for signals #194

TokisanGames opened this issue Aug 28, 2023 · 2 comments
Assignees
@TokisanGames
Labels
enhancement New feature or request
Milestone
0.9

Comments

@TokisanGames
Copy link
Owner

TokisanGames commented Aug 28, 2023 •
edited
Loading

Track godotengine/godot-cpp#1155

When merged, make functions that are public only so they can be called by signals private. Many classes have them, eg Terrain3DStorage
@TokisanGames TokisanGames added the bug Something isn't working label Aug 28, 2023
@TokisanGames TokisanGames added this to the Beta milestone Aug 28, 2023
@TokisanGames TokisanGames moved this to In Progress in Terrain3D Roadmap Aug 28, 2023
@TokisanGames TokisanGames self-assigned this Aug 28, 2023
@TokisanGames TokisanGames changed the title Height/Image Values offset --reuse Aug 28, 2023
@TokisanGames TokisanGames added enhancement New feature or request and removed bug Something isn't working labels Aug 28, 2023
@TokisanGames TokisanGames moved this from In Progress to Stable Release in Terrain3D Roadmap Aug 28, 2023
@TokisanGames TokisanGames modified the milestones: Beta, Stable Aug 28, 2023
@TokisanGames TokisanGames changed the title --reuse Privatize callable public functions used for signals Aug 28, 2023
@TokisanGames TokisanGames added the waiting for godot Bug or missing feature in the engine label Sep 3, 2023
@TokisanGames
Copy link
Owner Author

godotengine/godot-cpp#1155 and the corresponding function in the engine were merged and queued up for 4.2. Unknown if it will be backported to 4.1 before 4.2 is out in November.

@TokisanGames TokisanGames moved this from 1.0-Stable to 0.9.2 in Terrain3D Roadmap May 6, 2024
@TokisanGames TokisanGames modified the milestones: Stable 1.0.x, Beta 0.9.x May 6, 2024
@TokisanGames TokisanGames removed the waiting for godot Bug or missing feature in the engine label May 6, 2024
@TokisanGames
Copy link
Owner Author

Fixed by d74489b

@github-project-automation github-project-automation bot moved this from 0.9.2 to Done in Terrain3D Roadmap May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TokisanGames TokisanGames

Labels
enhancement New feature or request
Projects
Terrain3D Roadmap
Status: Done
Milestone
0.9
Development

No branches or pull requests
1 participant
@TokisanGames