Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PACKET_LOSSY_AV_RESERVED 8 # why? #610

Closed
zoff99 opened this issue Nov 2, 2017 · 2 comments
Closed

PACKET_LOSSY_AV_RESERVED 8 # why? #610

zoff99 opened this issue Nov 2, 2017 · 2 comments
Labels
messenger Messenger P3 Low priority question Questions
Milestone
v0.2.9

Comments

@zoff99
Copy link

zoff99 commented Nov 2, 2017

c-toxcore/toxcore/Messenger.h

Line 70 in 0542ffa

#define PACKET_LOSSY_AV_RESERVED 8 /* Number of lossy packet types at start of range reserved for A/V. */

why are there 8 packet types reserved for A/V ? are there more than 2 actually used?
@Diadlo
Copy link

Diadlo commented Nov 2, 2017

@zoff99 reserved != used. Probably it 8 was used to make protocol compatible, if new AV package will be added

@zoff99
Copy link
Author

zoff99 commented Nov 2, 2017

@Diadlo oh i see.
#609
this should also be changed i think. to make it more clear

@SkyzohKey SkyzohKey added question Questions messenger Messenger P3 Low priority labels Nov 19, 2017
@iphydf iphydf added this to the v0.2.x milestone Jul 16, 2018
@zoff99 zoff99 closed this as completed Nov 4, 2018
@iphydf iphydf mentioned this issue Nov 4, 2018
Open
@robinlinden robinlinden modified the milestones: v0.2.x, v0.2.9 Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
messenger Messenger P3 Low priority question Questions
Milestone
v0.2.9
Development

No branches or pull requests
6 participants
@Diadlo @zoff99 @robinlinden @SkyzohKey @iphydf @mannol