Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NGC: make savedata format all msgpack, not a mix of msgpack and custom binary stuff #2417

Open
iphydf opened this issue Nov 10, 2023 · 1 comment
Assignees
Milestone

Comments

@iphydf
Copy link
Member

iphydf commented Nov 10, 2023

Steps to make it backwards compatible (for a while):

  1. Change "save groups" to only write msgpack objects, no custom binary formats. Also merge state_bin and state_values.
  2. Change gc_load_unpack_group to check the array size: 6 means new format, 7 means old format.
  3. Add a set of "load" functions to load the new format.
  4. Release 0.2.19.
  5. Do stuff for 0.2.20.
  6. Release 0.2.20.
  7. Delete old format support; do stuff for 0.2.21.
  8. Release 0.2.21.

This way we'll have some backwards compatibility for 2 versions and then ditch it. Hopefully people have upgraded by then. If not, they may lose their groups.

@iphydf iphydf added this to the v0.2.19 milestone Nov 10, 2023
@iphydf iphydf moved this to Todo in DHT Group Chats Nov 15, 2023
@Green-Sky
Copy link
Member

After we drop the old compat, we could just fail to load the file, and error that the user should load the profile with 0.2.19 to convert the file.
#1944 is probably needed for failing.

@iphydf iphydf modified the milestones: v0.2.19, v0.2.20 Feb 11, 2024
@iphydf iphydf modified the milestones: v0.2.20, v0.2.21 Nov 6, 2024
@iphydf iphydf modified the milestones: v0.2.21, v0.2.x Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

3 participants