Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to disable local peer detection #221

Closed
Hasshu opened this issue Oct 29, 2016 · 6 comments
Closed

Option to disable local peer detection #221

Hasshu opened this issue Oct 29, 2016 · 6 comments
Assignees
@nurupo @e0ff
Labels
enhancement New feature for the user, not a new feature for build script help wanted Extra attention is needed network Network P3 Low priority
Milestone
v0.1.1

Comments

@Hasshu
Copy link

Hasshu commented Oct 29, 2016

Always-on local peer detection apparently can lead to a VPN leak, so having an option to disable it would be nice. (A warning in the tooltip might be a good idea, as well.)

See also qTox/qTox#2965 and irungentoo#1530.
@iphydf iphydf added this to the v0.0.4 milestone Oct 29, 2016
@iphydf iphydf added the enhancement New feature for the user, not a new feature for build script label Oct 29, 2016
@GrayHatter GrayHatter added the help wanted Extra attention is needed label Oct 29, 2016
@GrayHatter
Copy link

I'm happy to help, but I haven't started on this yet. So if you can fix this before me... It's a race, READY GO!

@SkyzohKey SkyzohKey added the network Network label Oct 30, 2016
@cleverca22
Copy link

related, i've found that the local peer detection partially breaks if you don't use port 33445, it can't detect the broadcast packets, but it will still send them out and be heard

@iphydf iphydf modified the milestones: v0.0.5, v0.0.4 Nov 7, 2016
@nurupo nurupo mentioned this issue Nov 10, 2016
Open
@GrayHatter GrayHatter modified the milestones: v0.0.6, v0.0.5 Nov 25, 2016
@GrayHatter
Copy link

@endoffile78 do you wanna try this one?

@e0ff
Copy link
Member

e0ff commented Nov 25, 2016

@GrayHatter Sure.

@e0ff e0ff mentioned this issue Dec 1, 2016
Closed
@iphydf iphydf modified the milestones: v0.0.6, v0.1.0, v0.1.1 Dec 10, 2016
@GrayHatter GrayHatter removed their assignment Dec 15, 2016
@iphydf
Copy link
Member

iphydf commented Dec 15, 2016

Done in #306.

@iphydf iphydf closed this as completed Dec 15, 2016
@Hasshu
Copy link
Author

Hasshu commented Dec 17, 2016

Ah, finally. Thanks to all who participated!

@iphydf iphydf added the P3 Low priority label Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nurupo nurupo

@e0ff e0ff

Labels
enhancement New feature for the user, not a new feature for build script help wanted Extra attention is needed network Network P3 Low priority
Milestone
v0.1.1
Development

No branches or pull requests
7 participants
@GrayHatter @cleverca22 @nurupo @SkyzohKey @iphydf @e0ff @Hasshu