Use Typescript 4.0 build features #105

niemyjski · 2017-06-28T13:35:28Z

I updated my local project to typescript 2.4 and ensured it was installed correctly and I removed my modules folder and made sure I don't have typescript installed globally. But every time my project runs it says version 2.3.4. I looked through the code and I don't see why this would be happing, do you have any ideas?

[TsProject] Building Project with: src/integrations/tsconfig.json
[TsProject] TypeScript compiler version:  2.3.4

The text was updated successfully, but these errors were encountered:

ToddThomson · 2017-12-20T19:52:49Z

@niemyjski I had a request to update tsproject to the latest version of Typescript. Are you still using/interested in TsProject?

niemyjski · 2017-12-20T21:30:22Z

Yes, we still use it and I don't think we can get off it unless it's easy to upgrade to something else. I noticed yesterday when I updated my deps that tsproject uses a specific version.

niemyjski · 2017-12-20T21:30:35Z

Any ideas if real bundling will be built into typescript some day?

ToddThomson · 2018-01-11T18:19:06Z

@niemyjski I began updating TsProject to utilize the latest Typescript version. There is an issue with a Typescript AST change which restricts identifier names to be changes ( the field is marked readonly ). This makes the minifier with TsProject fail.
I will need to test a fix for the problem and then conduct further testing to see if other issues present themselves.

niemyjski · 2018-01-12T03:00:36Z

Thanks for the update, really appreciate it.

niemyjski · 2018-05-03T12:09:43Z

I was just checking in to see if there was any status updates on latest ts support :)

slavafomin · 2018-07-27T15:28:01Z

Hello! Thank you for your effort. Are you planning to finish adding support for the latest TypeScript? We are looking for a way to create a merged type definitions and this tool looks like a good fit.

ToddThomson · 2018-07-27T15:39:55Z

@slavafomin I just don't have any time to make the changes required for the latest Typescript version. My apologies! PR would be welcomed!

niemyjski · 2019-06-13T13:53:27Z

I know everyone has very little time these days including myself. I was wondering if there was any time to upgrade the deps to latest typescript? I'd be willing to donate to be on latest :)

ToddThomson · 2019-06-13T17:06:50Z

@niemyjski Hi Blake. If I remember correctly, (it has been a long while since I last looked at the code) there were a few changes to the Typescript AST that caused grief. I will take a few hours to at least determine the scope of work.

ToddThomson · 2019-06-14T01:37:56Z

@niemyjski I am updating TsProject to utilize Typescript 3.5.x. You may have to do some testing...

Currently, TsProject builds using TS 3.5.1. I will update the GitHub source once I have done some testing.

ToddThomson · 2019-06-20T15:45:23Z

@niemyjski @slavafomin OK. I've finished my research into the scope of work required to bring TsProject up to date with Typescript 3.5.
Typescript has come a long way over the last couple of years! I can now make use of Transforms!

I will update the following task list to keep you informed on my progress:

Update solution space (TsTools) to utilize latest vs 2019.
Breakout Compiler to Ts2Js component.
Breakout Minifier source to TsMinifier component.
Breakout Bundler source to TsBundler component.
Breakout Common code to TsToolsCommon.
Update TsProject to utilize Ts2Js, TsBundler, TsMinifier and TsToolsCommon components.
Add Mocha testing framework to TsTool components
Add tests for each TsTool component
Testing Ts2Js, TsMinifier, TsBundler

Ts2Js is feature complete and testing is almost complete. Continuing to develop tests for TsMinifier and TsBundler.

ToddThomson · 2019-06-27T21:46:53Z

@niemyjski I am adding Mocha as the testing framework for TsTools. What is your opinion of Mocha vs other testing frameworks?

niemyjski · 2019-06-28T13:23:54Z

I don't have any preference, I've typically used mocha but I know there might be better alternatives out there but this works for me :) Thanks -Blake Niemyjski

…

On Thu, Jun 27, 2019 at 4:46 PM Todd Thomson ***@***.***> wrote: @niemyjski <https://github.com/niemyjski> I am adding Mocha as the testing framework for TsTools. What is your opinion of Mocha vs other testing frameworks? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#105?email_source=notifications&email_token=AAHZFIY4VIYI3UKL3R6OKL3P4UYM3A5CNFSM4DQ74XH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYYPAHY#issuecomment-506523679>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAHZFI762OOFLOB7SNY45YTP4UYM3ANCNFSM4DQ74XHQ> .

ToddThomson/tsproject#105

niemyjski · 2019-07-03T10:42:33Z

I see you pushed a release to TS2JS, do you know exactly what I'd need to do to update to the latest releases? I get that this project is now split? Or will this just be a dependency on that and I won't have to change much?

ToddThomson · 2019-07-03T16:10:30Z

@niemyjski

Or will this just be a dependency on that and I won't have to change much?

The Compiler (Ts2Js), Minifier, and Bundler are now just dependencies that TsProject will require. The TsProject.Src() function that is used within your gulp build pipeline will not change.
TsProject will just contain Typescript "Build" related features.

ToddThomson · 2019-07-12T20:37:48Z

Weekly update: The 3.0.0 release of all TsTool components is progressing. I am currently working on TsBundler and converting it to run as a Typescript custom transformer. Likely another week or 2 to get to a RC release for each.

niemyjski · 2019-07-16T10:57:22Z

Awesome, thank you for all of your work!

ToddThomson · 2019-07-30T15:30:22Z

@niemyjski I am currently working on release 3 of TsProject. Typescript 3.6 is opening the compiler API to project "build" features. I have decided that I will take a dependency on Typescript 3.6 for TsProject. It makes sense as the release of Typescript 3.6 will be in August and TsProject will likely be released towards the end of August.

niemyjski · 2019-07-30T20:37:46Z

Awesome!!! Thanks -Blake Niemyjski

…

On Tue, Jul 30, 2019 at 10:30 AM Todd Thomson ***@***.***> wrote: @niemyjski <https://github.com/niemyjski> I am currently working on release 3 of TsProject. Typescript 3.6 is opening the compiler API to project "build" features. I have decided that I will take a dependency on Typescript 3.6 for TsProject. It makes sense as the release of Typescript 3.6 will be in August and TsProject will likely be released towards the end of August. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#105?email_source=notifications&email_token=AAHZFI24BMHOJCJEP5Q45QLQCBNA5A5CNFSM4DQ74XH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3ELSTA#issuecomment-516471116>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAHZFI4Y2MADYVMJVCQCPL3QCBNA5ANCNFSM4DQ74XHQ> .

niemyjski · 2019-11-12T13:45:43Z

Looks like typescript 3.7 is out with some amazing features. Hoping they made it easy to upgrade to.

niemyjski · 2020-11-03T13:21:15Z

I've been running into some issues running all my tests (CORS and outdated samples...) but I think it's unrelated and I'll continue testing but I haven't ran into any errors so far. It seems to be running good from the e2e samples I've ran so far with the updated code. But I did have a question: Any ideas why it's voiding out all the exports?

exports.NodeSubmissionAdapter = exports.NodeFileStorageProvider = exports.NodeRequestInfoCollector = exports.NodeModuleCollector = exports.NodeErrorParser = exports.NodeEnvironmentInfoCollector = exports.NodeFileStorage = exports.KeyValueStorageBase = exports.InMemoryStorage = exports.SubmissionMethodPlugin = exports.RequestInfoPlugin = exports.ModuleInfoPlugin = exports.EventExclusionPlugin = exports.ErrorPlugin = exports.EnvironmentInfoPlugin = exports.DuplicateCheckerPlugin = exports.ConfigurationDefaultsPlugin = exports.EventBuilder = exports.SettingsResponse = exports.Configuration = exports.ContextData = exports.ExceptionlessClient = exports.SubmissionResponse = exports.SettingsManager = exports.Utils = exports.DefaultSubmissionClient = exports.InMemoryStorageProvider = exports.DefaultEventQueue = exports.EventPluginManager = exports.EventPluginContext = exports.ReferenceIdPlugin = exports.HeartbeatPlugin = exports.NullLog = exports.ConsoleLog = exports.DefaultLastReferenceIdManager = void 0;

ToddThomson · 2020-11-03T17:26:49Z

@niemyjski I don't have a context to look at the issue with your exports all being assigned with void. It is likely better that I continue with my testing and if you encounter a problem then I can look at the specifics.

niemyjski · 2020-11-09T03:00:28Z

I was curious if you ran into any issues? I haven't seen any yet other than this build error on the ci server (https://github.com/exceptionless/Exceptionless.JavaScript/runs/1371996235?check_suite_focus=true) but I'm getting to the point I'm going to be running mass e2e testing very soon.

  gulp build
3
  shell: /bin/bash -e {0}
4
  env:
5
    npm_config_cache: /home/runner/.npm
7
Error: Cannot find module '/home/runner/work/Exceptionless.JavaScript/Exceptionless.JavaScript/node_modules/tsproject/lib/tsproject.js'. Please verify that the package.json has a valid "main" entry
8
    at tryPackage (internal/modules/cjs/loader.js:303:19)
9
    at Function.Module._findPath (internal/modules/cjs/loader.js:516:18)
10
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:867:27)
11
    at Function.Module._load (internal/modules/cjs/loader.js:725:27)
12
    at Module.require (internal/modules/cjs/loader.js:952:19)
13
    at require (internal/modules/cjs/helpers.js:88:18)
14
    at Object.<anonymous> (/home/runner/work/Exceptionless.JavaScript/Exceptionless.JavaScript/gulpfile.js:7:19)
15
    at Module._compile (internal/modules/cjs/loader.js:1063:30)
16
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)
17
    at Module.load (internal/modules/cjs/loader.js:928:32) {
18
  code: 'MODULE_NOT_FOUND',
19
  path: '/home/runner/work/Exceptionless.JavaScript/Exceptionless.JavaScript/node_modules/tsproject/package.json',
20
  requestPath: 'tsproject'
21
}```

It looks like you are missing a main entry in the package.json. The weird part is I don't see this locally.

niemyjski · 2020-11-09T03:02:39Z

It looks like casing matters

  "main": "./lib/tsproject.js",
  "typings": "./lib/tsproject.d.ts",

niemyjski · 2020-11-09T03:05:29Z

I just submitted a pr which I think will resolve this issue.

* TypeScript 4.0 required src changes * Update to latest tsproject and typescript * npm install ts2js --save-dev * Resolve tsproject upgrade errors ToddThomson/tsproject#105 * Updated to latest beta * Revert "Resolve tsproject upgrade errors" This reverts commit dc61860. * Cleanup tsconfig * Updated packages * Updated dist * Upgraded to eslint * Fixed eslint errors * Added default exts * Updates to how we run unit tests * Added failing unit tests for resolving log levels based on settings order and null/empty sources * Got the vs code test code runner working! * Fixed unit test asserts for deep equality * Fixed some unit test issues. * Fixed several issues with resolving log levels and pattern matching * set plugin context cancelled to default to false instead of undefined. * Cleanup and update deps * Update dist * Fix quote

ToddThomson · 2020-11-09T18:09:25Z

@niemyjski Thank-you for your contribution to TsProject.

I have not found any issues with TsProject v4. I will soon publish a new NPM package with version 4.0.0-rc.1 with your changes ( and other small changes ).

niemyjski · 2020-11-09T19:50:00Z

Sounds great! Please let me know when you tag and push it

ToddThomson · 2020-11-09T20:55:33Z

@niemyjski NPM v4.0.0-rc.1 now published. Github dev branch has been updated to be in sync with my internal repository.

niemyjski · 2020-11-10T00:01:18Z

Thanks!

That resolved that issue but for some reason on linux I'm getting

[TsProject] src/exceptionless.ts(1,27): error TS2307: Cannot find module 'TraceKit' or its corresponding type declarations.
50
Error: [TsProject] /home/runner/work/Exceptionless.JavaScript/Exceptionless.JavaScript/src/services/DefaultErrorParser.ts(1,27): error TS2307: Cannot find module 'TraceKit' or its corresponding type declarations.

No idea why it doesn't fail on macOS, I'm also going to try on windows.

niemyjski · 2020-11-10T00:24:26Z

Looking at this closer something doesn't add up as the exceptionless.node.json file doesn't even have a reference to this parser at all. So I don't know why it's being referenced. Also the main tsconfig is resolving everything properly.

[00:15:00] Starting 'typescript.node'...
[TsProject] Building Project with: src/tsconfig.node.json
[TsProject] TypeScript compiler version:  4.0.5
[TsProject] Compiling project files...
[TsProject] src/exceptionless.ts(1,27): error TS2307: Cannot find module 'TraceKit' or its corresponding type declarations.
[TsProject] /home/codespace/workspace/Exceptionless.JavaScript/src/services/DefaultErrorParser.ts(1,27): error TS2307: Cannot find module 'TraceKit' or its corresponding type declarations.
[TsProject] Build completed with errors. Outputs generated.

Is there a good way to output the logs for this?

ToddThomson · 2020-11-10T18:38:02Z

@niemyjski You could just run tsc with full output verbosity. The output from above, TsProject is just doing the Ts compilation phase.

It appears that the module resolution by the typescript compiler is picking up TraceKit from somewhere.

niemyjski · 2020-11-10T18:42:43Z

Is there a good way to see what arguments tsproject is passing to tsc?

ToddThomson · 2020-11-10T19:07:48Z

TsProject does not use '''tsc'''. It uses the Typescript API.

All the configuration comes from the tsconfig.json file. TsProject doesn't add or change any config.

Try running tsc from the command line. It has many ways to peer into what Typescript module resolution is occurring.

ToddThomson · 2020-11-10T19:15:22Z

@niemyjski Try --traceresolution and perhaps --listfiles

niemyjski · 2020-11-11T14:47:25Z

I'm not even sure how I'd pass that to tsproject via gulp, will need to figure that out. Perhaps an option we can set in our tsconfig file that tsproject could pick up?

ToddThomson · 2020-11-11T15:41:54Z

@niemyjski Use tsc with --traceresolution. You don't need to use TsProject to just compile your project.

ToddThomson · 2020-11-11T18:35:44Z

@niemyjski I will also see if I can include module resolution host tracing in the 4.0 milestone. It looks easy, but I have other features which I want to complete first.

niemyjski · 2020-11-13T00:36:16Z

I think I might have to setup a build matrix or something, I get one weird error on windows and works perfectly fine on Mac but fails on linux (will have to setup a vm or something). I ran node node_modules/typescript/bin/tsc src/exceptionless.node.ts --traceresolution --target es5 --module commonjs --listfiles on both windows and Mac and I didn't see the file it's complaining about anywhere in the log.

This really makes me wonder if I should move to lerna. Just so tests and dependencies can be split out better

ToddThomson · 2020-11-13T01:03:08Z

See issue #115

This is just a CI build issue, correct? I've found that cleaning state (everything) within the CI env usually fixes these kind of weird issues. What packages include TraceKit that you are using? Can you search the node_modules dir to TraceKit references? Sorry I can't really help you out on this!

niemyjski · 2020-11-13T14:15:04Z

Thanks for #115!

I don't think so, there is something going on in linux as Windows and Mac work perfectly with rc2. I would think there would be extremely close similarities between macOS And Linux. If you were curious at the differences look at the linux build step https://github.com/exceptionless/Exceptionless.JavaScript/actions.

I take a hard dependency on TraceKit and there are no others that have a reference to it. I have a simple version of dependency injection. I define an interface in the core library that's shared and then at the entry point (each bundle target has it's own), I import the dependencies and set them on a singleton config instance (my di) and then these get flowed in. So in a bundle there is no way things are being resolved outside of the root file or across bundles unless something is being cached.

I'll try digging into this on linux dev container.

ToddThomson · 2020-11-13T17:22:42Z

@niemyjski Are you OK with me closing this issue? I'd like to push the production version of TsProject 4.0.0 to npm.

niemyjski · 2020-11-13T17:36:27Z

Yes, my only concern is what ever tests you have you may want to have a build matrix for them :)

niemyjski · 2020-11-15T15:41:06Z

@ToddThomson I just found a breaking issue in rc2 from rc1. In rc2 all the transpired files are placed next to the original (.d.ts, .js, .js.map). They shouldn't be created and they should be piped to the dist/temp folder in the same structure. I'm not sure what changed here I can try taking a look at the comit history

gulp.task('typescript', function typescript(done) {
  const stream = tsProject.src('src/tsconfig.json').pipe(gulp.dest('dist/temp'));
  stream.on('finish', done);
});

ToddThomson · 2020-11-15T17:49:04Z

@niemyjski Yes, the incremental compiler host now writes out the tsbuildinfo file and all individual js files. This is likely not the right thing to do. However, it will take a bit of time to determine the "right" thing to do. There is little info on the incremental API so I will need to go through the latest Typescript 4.1 code. Can you please start a new issue to track this?

ToddThomson · 2020-11-17T18:38:48Z

@niemyjski I have created issue #117 to track your issue.

Please also note issue #116. TsProject beyond release 4.0.x will become gulp-ts-bundler.

niemyjski · 2020-11-18T01:39:42Z

Thanks!

ToddThomson changed the title ~~Using latest versions of typescript.~~ Use latest versions of typescript. Jan 11, 2018

ToddThomson self-assigned this Jan 11, 2018

ToddThomson added the enhancement label Jan 11, 2018

ToddThomson added the In Development/Testing label Jan 11, 2018

ToddThomson changed the title ~~Use latest versions of typescript.~~ Use latest 3.5 version of Typescript. Jun 14, 2019

ToddThomson added this to the TsProject Release 3.0 milestone Jun 26, 2019

ToddThomson pinned this issue Jun 26, 2019

ToddThomson added a commit to ToddThomson/Ts2Js that referenced this issue Jun 29, 2019

Updated tests; NPM release 3.0.0-beta.8

c35f15d

ToddThomson/tsproject#105

ToddThomson changed the title ~~Use latest 3.5 version of Typescript.~~ Use Typescript 3.6 build features Jul 30, 2019

niemyjski mentioned this issue Nov 9, 2020

Fix Cannot find module #112

Merged

niemyjski closed this as completed Nov 13, 2020

ToddThomson unpinned this issue Nov 14, 2020

Use Typescript 4.0 build features #105

Use Typescript 4.0 build features #105

Comments

niemyjski commented Jun 28, 2017

ToddThomson commented Dec 20, 2017

niemyjski commented Dec 20, 2017

niemyjski commented Dec 20, 2017

ToddThomson commented Jan 11, 2018

niemyjski commented Jan 12, 2018

niemyjski commented May 3, 2018

slavafomin commented Jul 27, 2018

ToddThomson commented Jul 27, 2018

niemyjski commented Jun 13, 2019 • edited Loading

ToddThomson commented Jun 13, 2019

ToddThomson commented Jun 14, 2019

ToddThomson commented Jun 20, 2019 • edited Loading

ToddThomson commented Jun 27, 2019

niemyjski commented Jun 28, 2019 via email

niemyjski commented Jul 3, 2019 • edited Loading

ToddThomson commented Jul 3, 2019 • edited Loading

ToddThomson commented Jul 12, 2019

niemyjski commented Jul 16, 2019

ToddThomson commented Jul 30, 2019

niemyjski commented Jul 30, 2019 via email

niemyjski commented Nov 12, 2019

niemyjski commented Nov 3, 2020 • edited Loading

ToddThomson commented Nov 3, 2020

niemyjski commented Nov 9, 2020 • edited Loading

niemyjski commented Nov 9, 2020

niemyjski commented Nov 9, 2020

ToddThomson commented Nov 9, 2020

niemyjski commented Nov 9, 2020 • edited Loading

ToddThomson commented Nov 9, 2020

niemyjski commented Nov 10, 2020

niemyjski commented Nov 10, 2020 • edited Loading

ToddThomson commented Nov 10, 2020

niemyjski commented Nov 10, 2020

ToddThomson commented Nov 10, 2020

ToddThomson commented Nov 10, 2020

niemyjski commented Nov 11, 2020

ToddThomson commented Nov 11, 2020

ToddThomson commented Nov 11, 2020

niemyjski commented Nov 13, 2020 • edited Loading

ToddThomson commented Nov 13, 2020

niemyjski commented Nov 13, 2020

ToddThomson commented Nov 13, 2020

niemyjski commented Nov 13, 2020

niemyjski commented Nov 15, 2020

ToddThomson commented Nov 15, 2020

ToddThomson commented Nov 17, 2020

niemyjski commented Nov 18, 2020

niemyjski commented Jun 13, 2019 •

edited

Loading

ToddThomson commented Jun 20, 2019 •

edited

Loading

niemyjski commented Jul 3, 2019 •

edited

Loading

ToddThomson commented Jul 3, 2019 •

edited

Loading

niemyjski commented Nov 3, 2020 •

edited

Loading

niemyjski commented Nov 9, 2020 •

edited

Loading

niemyjski commented Nov 9, 2020 •

edited

Loading

niemyjski commented Nov 10, 2020 •

edited

Loading

niemyjski commented Nov 13, 2020 •

edited

Loading