Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote Sending to Actor with DNS name error #534

Closed
incizzle opened this issue Nov 27, 2024 · 7 comments · Fixed by #535
Closed

Remote Sending to Actor with DNS name error #534

incizzle opened this issue Nov 27, 2024 · 7 comments · Fixed by #535
Assignees
Labels
bug Something isn't working

Comments

@incizzle
Copy link

Bug description
Due to a recent change in https://github.com/Tochemey/goakt/blob/main/actors/actor_system.go#L1528 this now causes remote message sending to fail due to actor not having DNS name in id. Removing the call to this function resolves this issue.

How to reproduce it?
Set actor remote host to a DNS name and attempt a send from another actor on network to that DNS name.

Expected behavior
Should use DNS name for actors instead of resolved ip in id

Screenshots

Library Version:

  • Go-Akt version: 2.8.2
  • Go version: 1.23

Additional context

@incizzle incizzle added the bug Something isn't working label Nov 27, 2024
@Tochemey
Copy link
Owner

@incizzle this code is not new though. It has been around since version 2.6.0. Has it been working before? I don't mind fixing it.

@Tochemey
Copy link
Owner

@incizzle I have been able to reproduce it with one of the test. I push a fix in the course of the day.

@Tochemey
Copy link
Owner

@incizzle I will run more tests and cut a release today or morrow. Once again thanks for the findin

@incizzle
Copy link
Author

Thank you for the quick help with this. Goakt has been a great pkg looking forward to future updates 🫡

@Tochemey
Copy link
Owner

@incizzle I have cut a new release https://github.com/Tochemey/goakt/releases/tag/v2.8.3. Thanks for the feedback. Kindly star the repo if you have not :)

@Tochemey
Copy link
Owner

Tochemey commented Dec 1, 2024

@incizzle the DNS feature introduced some sort of issue with the clustering discovery engine. At the moment the hashicorp memberlist library does not handle well DNS. You can see some issues opened here:

I have reverted the changes to make sure the clustering engine works well in the new release https://github.com/Tochemey/goakt/releases/tag/v2.9.1. You can see how GoAkt handle the host address here

I hope to look into the DNS option at some point. I have an issue here to properly tackle it.

@incizzle
Copy link
Author

incizzle commented Dec 2, 2024

@incizzle the DNS feature introduced some sort of issue with the clustering discovery engine. At the moment the hashicorp memberlist library does not handle well DNS. You can see some issues opened here:

I have reverted the changes to make sure the clustering engine works well in the new release https://github.com/Tochemey/goakt/releases/tag/v2.9.1. You can see how GoAkt handle the host address here

I hope to look into the DNS option at some point. I have an issue here to properly tackle it.

Ok sounds good thanks for letting me know we ended up not needed remote messaging for our production app yet so this is fine on our side. Look forward to finding a solution to this eventually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants