-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connect user to chat to increase watchtime #47
Conversation
list user as viewer in selected chat viewtime increases while connected
Thank you for your contributing! 😃 I think there are a lot of things that should be changed. |
If you want you can take a look of this https://pypi.org/project/python-twitch-irc/ |
I had some issues getting pre-commit up and running on windows 😅 |
If you have a problem with pre-commit run the following commands:
So you can check the code manually 😃 |
@anoviel Have you the time for work on it? or do you prefer that I complete the review? |
…es. Rename some variables - See the PR Tkd-Alex#47 Reviews
…d with online-offline events. Currently It's working
Hi :) After a long time I've updated this PR. |
|
The script workings as well with on-line/offline events? Because currently I don't know what happened when a streamer go offline and then online again |
I am not sure about that too. I have not seen this happen in 2 hours just looking at the script work :/ |
We need a long - running test. |
Someone could also just open a Private Window/Incognito Tab and check in the Twitch Chat´s Memberlist, if the Accountname is listed. If so, the feature works as intended. It even works for more than 2 streamers, given that the viewlimit does not apply to Twitch Chat. Glad that this was considered in the PR. However, the new feature draws attention to 2 things:
It might be attractive for someone that migrates from another solutions to this software to join the IRC from channels that don't support Channel Points, regardless of the intentional purpose of the software. The reasons for that can vary, like the Watchtime example @anoviel mentioned before, farming alternative currencies such as StreamElements/StreamHeroes (which are measured by time active in chat), qualifying for drops or subscription gifts (which select random people that were in the chatbox in the last x hours) or more. People could put those streams simply on the very bottom of the list, but assuming every other stream in the list is offline, they might up creating load on script and network for farming Viewtime on a stream it is not worth it... unless there is a way to detect that a channel doesn't support Channel Points?
This sounds really odd in the first moment, but there are Streamer which are actually checking and rewarding people for the time they spend in Chatbox regardless of the Stream's Online State. The reasons for that can vary over wanting to maintain an active chat, even if offline (to make the impression of a healthy/active community) or sometimes even easier: using a selfcoded bot and messing up the Online-Check for it. Once again there would probably be a setting required to join Streamer´s IRC regardless of their Online State, but at this point it might be even better for the readability and usability to have a seperate list of Streamers in the run.py where people can put streams that are exclusive for IRC usage and configure the behaviour with Offline Streams there, before the "StreamerSettings" in |
The latest log (which has been running since last night) takes 100MB because it is saving the messages in the IRC channels. I don't think I can share it but I have received a couple of errors today. |
They are all messages from irc chat. |
This was already tried and obviously the script It's working. We need just to check If the bot works when a streamer goes offline and online 😄 - I'm currently testing.
I think yes, should be a way. If you can provide a streamer without channel points maybe I can't find a way. uhm agree, your message make sense. I got your points. |
Are you able to edit add a time sleep here? import time
....
code
code
....
self.reactor.process_once(timeout=0.2)
time.sleep(0.01) We could also surround with |
Bruh, it just fixed itself without me making any changes. |
Awesome! 🤣 |
Not want to advertise Streamers, but you could take a look into Twitch's "Slots" Category. Streamer which exclusively stream Slots don't meet the requirements for Affiliation/Partnership and can't enable Channel Points because of that.
Oh, sure. I am just extremly unexperienced with Github in general. Should learn that at some point. Limiting it to theorycrafting most of the time for now. I really appreciate help with that. |
…or("threads can only be started once")
Seems to be stable. @PureFallen after the merge please open a new issue. You can easily do a Copy & Paste or open new issue directly via GitHub. |
Left the script running over this night. After reading logs, no issues have been found. (Despite this issue #47 (comment) but it fixed itself. ) |
Is it currently working? Unfortunately it doesn't work for me. My nickname is not in the list of users on the stream. And the viewing time at Streamelements is obviously not increasing. |
Please open a new issue and post your settings. Make sure to have |
add irc chat client
list user as viewer in selected chat
viewtime increases while connected
Referenced issue
gottagofaster236/Twitch-Channel-Points-Miner#16