Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zarr 3.0 compatibility #904

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from
Draft

Zarr 3.0 compatibility #904

wants to merge 7 commits into from

Conversation

measty
Copy link
Collaborator

@measty measty commented Jan 16, 2025

Fixes the error related to zarr.errors.FSPathExistNotDir

It doesnt exist anymore since zarr v3.0.0, which instead just raises a standard FileNotFoundError

rather than checking for different error types in different versions of zarr, i've just removed the check for specific error type in favour of any errors

There are some other changes which we need to deal with from 3.0 also, as it has removed or changed zarr.LRUStoreCache, zarr.DirectoryStore, and zarr.SQLiteStore all of which tiatoolbox uses

We would also need to wait for tifffile to update to be compatible with zarr 3.0

See: https://zarr.readthedocs.io/en/latest/user-guide/v3_migration.html for more details

@measty measty changed the title fix zarr checking Zarr 3.0 compatibility Jan 16, 2025
@measty measty marked this pull request as draft January 16, 2025 14:11
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.88%. Comparing base (d82df5c) to head (2212eef).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #904      +/-   ##
===========================================
- Coverage    99.90%   99.88%   -0.03%     
===========================================
  Files           70       70              
  Lines         8735     8735              
  Branches      1149     1149              
===========================================
- Hits          8727     8725       -2     
- Misses           3        5       +2     
  Partials         5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@measty measty mentioned this pull request Jan 16, 2025
@shaneahmed shaneahmed added bug Something isn't working dependencies Pull requests that update a dependency file labels Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants