Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread.isAlive was renamed to Thread.is_alive in python 3.9 #1

Closed
PiRK opened this issue Dec 16, 2021 · 3 comments
Closed

Thread.isAlive was renamed to Thread.is_alive in python 3.9 #1

PiRK opened this issue Dec 16, 2021 · 3 comments

Comments

@PiRK
Copy link

PiRK commented Dec 16, 2021

This causes an error when a transaction is received or sent with the development version (run from source) of Electron Cash or Electrum ABC (released versions currently ship with python 3.8, so for now it should still work).

Traceback
Traceback (most recent call last):
  File "/home/totor/.electrum-abc/external_plugins/AutoCove-Plugin.zip/AutoCove/qt.py", line 160, in history_updated
    if self.Thread.isAlive(): return    #Don't double broadcast the same return.
AttributeError: 'Thread' object has no attribute 'isAlive'
@TinosNitso
Copy link
Owner

Thanks for letting me know! I'm guessing I should probably use .is_alive() instead, but I'll need to learn how to run the dev version (never done it). Their might be a new attribute. I'll try figure it out tomorrow. For now I'm spelling out all the OpCodes in mixed case, so that it auto-decodes either using OpCodes or OP_CODES (another QCheckBox toggle). e.g. OP_OUTPOINTTXHASH vs OutpointTXHash.

@PiRK
Copy link
Author

PiRK commented Dec 16, 2021

Luckily, running from sources is relatively easy if you are familiar with terminals.

Installing the mandatory dependencies is basically these 3 commands:

git clone https://github.com/Electron-Cash/Electron-Cash; cd Electron-Cash
pip install -r contrib/requirements/requirements.txt --user
pip install pyqt5

And then, run with ./electron-cash, or python3 ./electron-cash

Electron Cash's README has additional instructions, if you want the optional dependencies: https://github.com/Electron-Cash/Electron-Cash/blob/master/README.rst

Thanks for the useful plugin!

@TinosNitso
Copy link
Owner

I've released v1.0.4 which should resolve this issue. However I should still check for myself. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants