Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge from master #3

Merged
merged 16 commits into from
Aug 13, 2019
Merged

merge from master #3

merged 16 commits into from
Aug 13, 2019

Conversation

TinaHu1
Copy link
Owner

@TinaHu1 TinaHu1 commented Aug 13, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

Tiano2017 and others added 16 commits August 9, 2019 15:54
* added cases missing properties + updated examples + added case comments api + added OData parameters

* added required properties

* fixes

* more fixes

* fixed CreateCaseComment + CreateCase request parameters

* some fixes

* changes assignedTo property name to owner + added more values to closeReason enum

* set x-nullable to true in UserInfo.objectId

* undo last commit

* removed x-ms-odata, x-nullable returned
* copy from private repo

* fix responses

* fix readme

* fix list fileservices

* Use cors definition from blob.json
Remove empty body for RESPONSE_SCHEMA_NOT_IN_SPEC errors
- Remove properties from parameters for lease, and correct as later examples
…version stable/2019-08-01 (#6859)

* Adds base for updating Microsoft.ContainerService from version stable/2019-06-01 to version 2019-08-01

* Updates readme

* Updates API version in new specs and examples

* Update API spec for 2019-08-01

* Update tags for 2019-08-01 SDK generation

* Add one more space to tag
Remove empty body for RESPONSE_SCHEMA_NOT_IN_SPEC errors
- Remove empty body for RESPONSE_SCHEMA_NOT_IN_SPEC errors
- Add missing "value" for body that was set as array
* IMDS Swagger for 2019-02-01

* Added IMDS version 2019-08-01

* Added 2019-04-30 to readme

* Whitespace

* Capitalization of example files

* -Removed extraneous security definitions
-Added http to schemes

* Added suppressions for https and security definitions

* Indentation

* More indentation
Remove "description" in exampe because it's not in model
@TinaHu1 TinaHu1 merged commit 07dcf30 into TinaHu1:master Aug 13, 2019
TinaHu1 pushed a commit that referenced this pull request Mar 4, 2020
* Add encryption scope API to 2019-06-01.

Add encryption scope API to 2019-06-01.

* Address CI failures.

* Fix CI failures #2.

* Address CI failures #3.

Co-authored-by: Anthony Kunnel Jose <[email protected]>
TinaHu1 pushed a commit that referenced this pull request Mar 4, 2020
* 2019-08-09-preview

* spell out networks

* username and credential needed to add an IdentitySource

* post listAdminCredentials

* standardize on username, password, nsxt and vcenter

* add nsxt to custom-words.txt

* default cluster does not have provisioningState

* it extends DefaultClusterProperties

* add Circuit expressRoutePrivatePeeringID

* back out some minor changes for sdk generation

* identitySources and Circuit authorizations are updateable

* add PrivateClouds_ListInSubscription

* Long running operation for Clusters_Delete (#1)

* npm run prettier

* location for all resources (#2)

* Revert "location for all resources (#2)" (#3)

This reverts commit 432e37b.

* add description TODOs

* example is PrivateClouds_Update

* require body in PrivateClouds_Update

* replaced TODOs with descriptions

* spellcheck

* "x-ms-secret": true

* Revert ""x-ms-secret": true"

This reverts commit 3358dff.

Co-authored-by: Andrew Ulliani <[email protected]>
Co-authored-by: Eugene Tolmachev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants