Code

Correct/Simplify the Ack algorithm#177

Code

Merged

jstnlef merged 23 commits intoTimonPost:masterTimonPost/laminar:masterfrom jstnlef:correct-ack-algorithmjstnlef/laminar:correct-ack-algorithmCopy head branch name to clipboardApr 30, 2019

+566-691

Commits

Commits on Apr 29, 2019

• remove some warnings

  jstnlef

  committed
  2c8327f

  Copy full SHA for 2c8327f

• work in progress change. Includes reimplementation of the sequence buffer to handle edge cases

  jstnlef

  committed
  e8e0d9c

  Copy full SHA for e8e0d9c

• move sequence buffer into the module definition

  jstnlef

  committed
  c1628ad

  Copy full SHA for c1628ad

• finish implementation of the new acking algorithm

  jstnlef

  committed
  f698195

  Copy full SHA for f698195

• modify the dropped packet algorithm slightly to prevent and extra vector allocation. Also removes the external_ack and local_ack files

  jstnlef

  committed
  a66f4c7

  Copy full SHA for a66f4c7

• fix typo in the name of the acknowledgement module

  jstnlef

  committed
  5243df6

  Copy full SHA for 5243df6

• fix the tests to point to the right module and remove some print debug lines

  jstnlef

  committed
  56910ad

  Copy full SHA for 56910ad

• clean up some compiler warnings

  jstnlef

  committed
  b252f8a

  Copy full SHA for b252f8a

• standardize on a single spelling of acknowledgment

  jstnlef

  committed
  8d9b013

  Copy full SHA for 8d9b013

• remove the dropped packets property from Acknowledgment handler and have it generate on the fly when called

  jstnlef

  committed
  b779c2f

  Copy full SHA for b779c2f

• ran a cargo fmt

  jstnlef

  committed
  d3f1d9a

  Copy full SHA for d3f1d9a

• fix clippy warnings

  jstnlef

  committed
  43ef7b1

  Copy full SHA for 43ef7b1

• add a couple more tests for the sequence buffer

  jstnlef

  committed
  21aa27f

  Copy full SHA for 21aa27f

• fix an off-by-one error I had in the new acking impl

  jstnlef

  committed
  7a74da9

  Copy full SHA for 7a74da9

• add some more checks and a comment around acking_many_packets_with_packet_drop method

  jstnlef

  committed
  04f9f91

  Copy full SHA for 04f9f91

• turns out testing is useful

  Show description for 87a2c0e
  jstnlef

  committed
  87a2c0e

  Copy full SHA for 87a2c0e

• stop sending duplicate packets until we have a valid message from the server specifying packets we've dropped

  jstnlef

  committed
  864e04d

  Copy full SHA for 864e04d

• needed to run a fmt

  jstnlef

  committed
  04273a9

  Copy full SHA for 04273a9

• lets default this to some size. 256 should do

  jstnlef

  committed
  b2009d6

  Copy full SHA for b2009d6

• fix a typo in should_send_packet comment

  jstnlef

  committed
  b5f1fe6

  Copy full SHA for b5f1fe6

• move the processing of the packet to after the drops are processed

  jstnlef

  committed
  04f98cc

  Copy full SHA for 04f98cc

• added a couple more tests and an off by one in the remove_entries function

  jstnlef

  committed
  001250d

  Copy full SHA for 001250d

• ran another fmt

  jstnlef

  committed
  6b9c9ac

  Copy full SHA for 6b9c9ac