Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unimproved termination should not terminate during CH #731

Closed
ge0ffrey opened this issue Mar 21, 2024 · 0 comments · Fixed by #755
Closed

Unimproved termination should not terminate during CH #731

ge0ffrey opened this issue Mar 21, 2024 · 0 comments · Fixed by #755
Assignees
@triceo
Labels
enhancement New feature or request
Milestone
v1.9.0

Comments

@ge0ffrey
Copy link
Contributor

An unimproved termination should never active during a CH, because that's going to improve significantly when it finishes that CH phase anyway.

Note:
A CH could send a new best solution event every time one more extra planning variable is assigned.
It doesn't, because nobody needs that and it incurs a heavy performance cost due to solution cloning. Lets not change that.
@ge0ffrey ge0ffrey added enhancement New feature or request process/needs triage Requires initial assessment of validity, priority etc. labels Mar 21, 2024
@triceo triceo removed the process/needs triage Requires initial assessment of validity, priority etc. label Mar 21, 2024
@triceo triceo mentioned this issue Mar 27, 2024
Merged
@triceo triceo added this to the v1.9.0 milestone Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@triceo triceo

Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.9.0
Development

Successfully merging a pull request may close this issue.

fix: unimproved terminations skip construction heuristic triceo/timefold-solver
3 participants
@ge0ffrey @triceo @pieterdeschepper