-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: pass use_fast
parameter to get_tokenizer
#106
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! There are only a few tiny changes that need to be made.
@felixgwu after a few attempts I'm still getting failed tests due to OOM ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me now. I can either merge it or wait if you would like to spend more time on fixing the Travis CI. I really appreciate your help!
ok, let see if I can devote more time to fixing the tests, otherwise, feel free to merge it. |
I've refactored the tests a bit. I also added the missing assert statement to
|
It looked good to me, so I just merged them. I would like to keep using |
A proposed solution for the issue #105