Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional geoms #180

Open
32 tasks
rdboyes opened this issue Feb 18, 2025 · 3 comments
Open
32 tasks

Add additional geoms #180

rdboyes opened this issue Feb 18, 2025 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@rdboyes
Copy link
Member

rdboyes commented Feb 18, 2025

Describe how it works in R's ggplot2
Add geoms! This is a list of the currently non-implemented geoms that are available in ggplot2 in R. For the easier geoms, something similar to the RainCloud example in the ReadMe should get basic functionality working. From there:

  • Test that the geom is able to generate a few example plots
  • Add those as unit tests with corresponding Makie SpecApi plots (see test/test_geoms.jl for the general idea).
  • Add parameters to the legend dictionaries in src/attributes.jl
  • Add to the ggplot_to_makie translation dict if there are options or aesthetics that need to be translated to what they are called in Makie
  • If there are options in the plot that require a specific type as input, add them to the type conversion dict
  • Add a reference documentation page. The one from the corresponding page in ggplot2 (or the one from the Makie.jl plot) should give a good starting point, or see the one for geom_point here.

See #182 for an example pull request that implements geom_rainclouds.

Easier:

Harder (no direct match in base Makie, or calculations/arg handling required):

Describe any changes you think should be made to R's version
These additional geoms should be doable without any major changes to Makie:

@rdboyes rdboyes added enhancement New feature or request good first issue Good for newcomers labels Feb 18, 2025
@rdboyes rdboyes assigned rdboyes and unassigned rdboyes Feb 18, 2025
@asinghvi17
Copy link

Jitter is implemented in SwarmMakie.jl (as is geom_beeswarm), just FYI

@rdboyes
Copy link
Member Author

rdboyes commented Feb 19, 2025

Jitter is implemented in SwarmMakie.jl (as is geom_beeswarm), just FYI

Thanks! I'll include a link in the main issue

@adknudson
Copy link
Member

It's been a while since I've looked at the code base, but I'll try to knock out some of the easier geoms the next few days, and then I'll see about taking on the harder ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants