Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Org-id with space AND new line character breaking org/grant page #217

Closed
michaelwood opened this issue Nov 29, 2022 · 4 comments
Closed
Assignees
Labels

Comments

@michaelwood
Copy link
Member

NoReverseMatch: Reverse for 'org' with arguments '('GB-CHC- \n1113528 ',)' not found. 1 pattern(s) tried: ['org/(.*)$']
(20 additional frame(s) were not displayed)
...
  File "grantnav/frontend/views.py", line 931, in grant
    return render(request, "grant.html", context=context)
<div class="interface" style="font-weight: 300; margin-bottom: 30px">
  <h3 class="title" style="font-weight: 700; font-size: 18px; margin: 0 0 15px">Request</h3>
URL https://grantnav.threesixtygiving.org/grant/360G-JRF-YCMAY201709

Django templates don't allow theses characters in the parameters for a {% url %} we will need to do a bit of data cleaning on org-ids.

@michaelwood
Copy link
Member Author

We're going to handle this in the standard and has currently been added to the dqt - ThreeSixtyGiving/standard#387

@michaelwood michaelwood transferred this issue from ThreeSixtyGiving/grantnav Aug 14, 2024
@michaelwood
Copy link
Member Author

We will fix this for now by replacing the chars on import to something slug compatible. We may also do this for org-ids .

@mariongalley
Copy link

Is this fixed by the recent change to exclude grants with line breaks @michaelwood?

@R2ZER0
Copy link
Contributor

R2ZER0 commented Oct 11, 2024

@mariongalley Yes I believe excluding these grants should have fixed this issues

@R2ZER0 R2ZER0 closed this as completed Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants