Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow domain whitelisting #1

Closed
bb010g opened this issue Jul 26, 2018 · 11 comments
Closed

Allow domain whitelisting #1

bb010g opened this issue Jul 26, 2018 · 11 comments
Labels
good first issue Good for newcomers

Comments

@bb010g
Copy link

bb010g commented Jul 26, 2018

I'm fine with X-Frame-Origin being used on most sites, but there are a couple sites that I do want it cleaned on, so it'd be nice if the user could specify a whitelist of domains (or maybe regexes on URLs) that the cleaning would take effect on.

@ThomazPom
Copy link
Owner

Sure, i'll implement a regexp white list, default with *

@ThomazPom
Copy link
Owner

Implemented in this commit

Default allowed urls :

http://*/*
https://*/*

@ThomazPom
Copy link
Owner

App has been updated in mozilla store

@ThomazPom ThomazPom added the good first issue Good for newcomers label Jul 26, 2018
@Goury
Copy link

Goury commented Jul 27, 2019

And how are we supposed to edit this whitelist?
Doesn't seem to be a way through the interface.

@ThomazPom
Copy link
Owner

Image

@Goury
Copy link

Goury commented Jul 27, 2019

Hmm..
Firefox doesn't show me this button for reasons unbeknownst to me =(

I am using 68.0.1-ubuntu

@ThomazPom
Copy link
Owner

Image

@Goury
Copy link

Goury commented Jul 27, 2019

If only it was that easy.
I'll go hack my custom profile, most likely it's something in there.

@ThomazPom
Copy link
Owner

ThomazPom commented Jul 27, 2019

Tell me if you find how, i'm curious

@bb010g
Copy link
Author

bb010g commented Jul 27, 2019

Oh yeah, got a notification for this, and not sure if you'd want to maybe allow this via a UI toggle, but if you want to take match patterns too instead of straight regexes, I ended up posting https://github.com/bb010g/match-pattern-to-regexp (CC0) while doing Anarchist Framer. (Based off of a MDN wiki function that got pulled when I edited in improvements.)

They're generally saner to read & write for URLs.

@Goury
Copy link

Goury commented Jul 28, 2019

So I am not sure how and why, but after migrating everything to a fresh new profile it started working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants