Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish litps to npm? #2

Open
paluh opened this issue Dec 3, 2018 · 9 comments
Open

Publish litps to npm? #2

paluh opened this issue Dec 3, 2018 · 9 comments

Comments

@paluh
Copy link
Contributor

paluh commented Dec 3, 2018

Maybe we can distribute compiled litps with npm. What do you think?

@paluh
Copy link
Contributor Author

paluh commented Dec 5, 2018

P.S.
@Thimoteus It seems that we can rip this piece from pscid or pulp.

@Thimoteus
Copy link
Owner

Yeah, probably worth looking into, though I've never published a binary on npm before.

@paluh
Copy link
Contributor Author

paluh commented Dec 6, 2018

I've not done this before too. It seems that literate-purescript is already taken on npm. Do you think that litps is good as a package name?

@paluh
Copy link
Contributor Author

paluh commented Dec 6, 2018

Following pscid package.json and .npmignore I've created dirty experimental publish workflow which works fine:

paluh@cc8c02d

I'm not sure if this is the most beautiful approach as it adds index.js into the repo and doesn't bundle anything but copies the whole ./output dir into published package.

Do we want to take this easy route?

@paluh
Copy link
Contributor Author

paluh commented Dec 6, 2018

P.S.
So npm install paluh-litps then paluh-litps --help works fine.

@Thimoteus
Copy link
Owner

As long as it's maintainable, it should be fine 🤷‍♂️

@paluh
Copy link
Contributor Author

paluh commented Dec 7, 2018

@Thimoteus
It seems to be maintainable as pscid is long standing project already.

  1. Should I provide a PR with this solution?

  2. Would you be so kind and publish a package yourself? This process requires a registration and npm authentication but it gives you a full control over package release, publishing and unpublishing.

@paluh
Copy link
Contributor Author

paluh commented Dec 16, 2018

@Thimoteus I don't want to bother you but maybe you can find a moment and consider answering above two questions ;-)

@Thimoteus
Copy link
Owner

Hey, I don't think I'll have time to look into this this week, but I've added a reminder for next weekend, so I'll let you know then. For now, you can make a PR and I'll take a look over the weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants