Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_tk_comment function in template-tags using old version of media object #48

Open
bslugger opened this issue Mar 25, 2015 · 2 comments
Open

Comments

@bslugger
Copy link

Issue:
Since a comment box uses the .media-body class, this class uses a width of 10000px in an attempt to size the panel-default. However, when a comment has a really long string (for example, a long URL), it causes the panel to break and the viewer can't see what is written past the container.

Suggested Correction:
v3.3.0 bootstrap has moved away from using .pull-left on a media object (such as a comment avatar) and now employs a .media-left and .media-right class (see: http://getbootstrap.com/components/#media). Please update the _tk_comment function to employ this new structure.

@svenl77
Copy link
Contributor

svenl77 commented Feb 29, 2016

@bslugger @konradsroka Is this issue still relevant or fixed already?

@Ixiter
Copy link
Contributor

Ixiter commented Jun 13, 2016

Still not fixed.
In Chrome it messes up, in firefox it looks pretty good.
It seems, Chrome handels display:table-cell; different than ff.

Though .. also in the example, a long url is overflow hidden. So a media-left wouldnt help here. With media-left, the avatar hides in chrome, no matter how wide the comment content is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants